test: [M3-7395] Add new cypress tests to longview landing page #10321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliu-akamai
requested review from
jdamore-linode
and removed request for
a team
|
Coverage Report: ✅ |
jdamore-linode
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Great work @cliu-akamai, really nicely done! Approved pending removal of that stray .skip() (edit: and changeset!)
| @@ -103,7 +111,7 @@ describe('longview', () => { | |||
| * - Creates a Linode, connects to it via SSH, and installs Longview using the given cURL command. | |||
| * - Confirms that Cloud Manager UI updates to reflect Longview installation and data. | |||
| */ | |||
| it('can install Longview client on a Linode', () => { | |||
| it.skip('can install Longview client on a Linode', () => { | |||
There was a problem hiding this comment.
Suggested change
| it.skip('can install Longview client on a Linode', () => { | |
| it('can install Longview client on a Linode', () => { |
| cy.wait('@ceateLongviewClient'); | ||
|
|
||
| // Confirms that UI updates to show the new client when creating one. | ||
| cy.findByText(`longview-client-${client.id}`).should('be.visible'); |
There was a problem hiding this comment.
Suggested change
| cy.findByText(`longview-client-${client.id}`).should('be.visible'); | |
| cy.findByText(`${client.label}`).should('be.visible'); |
Very minor change, but this way if the Longview client factory label ever changes the test will still pass 👍
cliu-akamai
requested review from
bnussman-akamai and
jaalah-akamai
and removed request for
bnussman-akamai
cliu-akamai
force-pushed
the
feature/M3-7395
branch
from
5af58f5
to
65f1951
Compare
cliu-akamai
requested review from
dwiley-akamai and
hkhalil-akamai
and removed request for
a team
dwiley-akamai
approved these changes
Apr 4, 2024
| "@linode/manager": Tests | ||
| --- | ||
|
|
||
| Add new cypress tests to longview landing page ([#10321](https://github.com/linode/manager/pull/10321)) |
There was a problem hiding this comment.
Suggested change
| Add new cypress tests to longview landing page ([#10321](https://github.com/linode/manager/pull/10321)) | |
| Add new Cypress tests for Longview landing page ([#10321](https://github.com/linode/manager/pull/10321)) |
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add new tests to check the empty state message in Longview landing page.
Major Changes 🔄
How to test 🧪