change: [M3-7873] - Use Chip for notification badge #10333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hana-linode
requested review from
carrillo-erik and
hkhalil-akamai
and removed request for
a team
bnussman-akamai
approved these changes
Mar 29, 2024
| @@ -135,7 +135,12 @@ export const NotificationMenu = () => { | |||
| <NotificationIconWrapper isMenuOpen={notificationContext.menuOpen}> | |||
| <Bell /> | |||
| {numNotifications > 0 ? ( | |||
mjac0bs
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Nice change! Confirmed things look good at desktop/tablet/mobile viewports for various #s of notifications.
We do see the chip display next, instead of overlapping, to the notification icon at screens < 370 wide, but that's the case in prod now even with the circular badge icon, so I don't think we generally support screens that small.
| Single digits | 3 or more digits |
|---|---|
 |
 |
|
Coverage Report: ✅ |
jdamore-linode
approved these changes
Mar 29, 2024
|
Such a little thing but this has bugged me forever! Thanks @HanaXu |
hkhalil-akamai
approved these changes
Mar 29, 2024
bnussman-akamai
pushed a commit
to bnussman-akamai/manager
that referenced
this pull request
Apr 4, 2024
## Description 📝 When the Notification count is past 100, the numbers become difficult to read because their edges appear outside the colored dot. I decided to use the chip component to better display the Notification count. ## How to test 🧪 ### Verification steps (How to verify changes) - Update the label to a 3 digit number on line 141 of `NotificationMenu.tsx` - Confirm the notification badge display in the top right corner
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
When the Notification count is past 100, the numbers become difficult to read because their edges appear outside the colored dot. I decided to use the chip component to better display the Notification count.
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
NotificationMenu.tsxAs an Author I have considered 🤔
Check all that apply