Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-7797] - Add Cypress tests for Account billing drawers #10349

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

cliu-akamai
Copy link
Contributor

Description 📝

Add new tests to check the Account billing drawers.

Major Changes 🔄

  • Add new cypress tests to tests Make a Payment, Update Billing Contact Information, and Add Payment Method access will be disabled for restricted users or child user accounts

How to test 🧪

yarn cy:run -s "cypress/e2e/core/billing/restricted-user-billing.spec.ts"

@cliu-akamai cliu-akamai requested a review from a team as a code owner April 3, 2024 19:07
@cliu-akamai cliu-akamai requested review from jdamore-linode, mjac0bs and bnussman-akamai and removed request for a team April 3, 2024 19:07
Copy link

github-actions bot commented Apr 3, 2024

Coverage Report:
Base Coverage: 81.7%
Current Coverage: 81.7%

@mjac0bs mjac0bs changed the title M3-7797 Add Cypress tests for Account billing drawers test: [M3-7797] - Add Cypress tests for Account billing drawers Apr 3, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Cassie! Please add a changeset under Tests and this looks good to me.

Since we already had test coverage for "Update Billing Contact Information" and "Add Payment Method", I confirmed this PR takes care of testing enabled/disabled access to the last piece of this ticket, "Make a Payment" and all tests pass.

image

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cassie, looks great! Approved pending the changeset that @mjac0bs mentioned

@cliu-akamai cliu-akamai requested a review from a team as a code owner April 4, 2024 18:03
@cliu-akamai cliu-akamai requested review from hana-linode and carrillo-erik and removed request for a team April 4, 2024 18:03
@cliu-akamai cliu-akamai merged commit 7b79662 into linode:develop Apr 5, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants