Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-7959] - Update gecko feature flag to object #10363

Merged

Conversation

hana-linode
Copy link
Contributor

@hana-linode hana-linode commented Apr 8, 2024

Description πŸ“

Update the gecko feature flag from a boolean to an object so we can have more granular control for Beta/GA

Changes πŸ”„

  • Use gecko2 object feature flag over gecko feature flag
  • Add placeholder logic for GA for the Linode's landing page and region select

Preview πŸ“·

Gecko Beta Gecko GA
image Screenshot 2024-04-08 at 5 24 50β€―PM
Screenshot 2024-04-08 at 5 25 53β€―PM image

How to test πŸ§ͺ

Prerequisites

  • Ensure you have the gecko customer tag (reach out for more info)

Verification steps

Note: You may need to click reset to LD defaults flags in dev tools after each variation switch to see the changes

  • On LD development, test the gecko2 variations:
    • Feature ON, GA OFF
      • No GA Gecko text on the Linode's landing or region select in Linode Create
      • Gecko Beta features display as expected (See M3-7491 for feature overview)
    • Feature ON, GA ON
      • You should see GA Gecko text on the Linode's landing and region select in Linode Create
      • Gecko Beta features display as expected except for the above overwritten for GA
    • Everything OFF (you can just uncheck the Gecko feature flag in the dev tools)
      • You should see no Gecko features

As an Author I have considered πŸ€”

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

@hana-linode hana-linode added the Gecko GA Relating to Gecko GA label Apr 8, 2024
@hana-linode hana-linode self-assigned this Apr 8, 2024
@hana-linode hana-linode requested a review from a team as a code owner April 8, 2024 21:50
@hana-linode hana-linode requested review from bnussman-akamai and abailly-akamai and removed request for a team April 8, 2024 21:50
Copy link

github-actions bot commented Apr 8, 2024

Coverage Report: ❌
Base Coverage: 81.8%
Current Coverage: 81.79%

@abailly-akamai abailly-akamai self-requested a review April 10, 2024 16:09
@@ -474,7 +474,7 @@ export class LinodeCreate extends React.PureComponent<
(imageIsCloudInitCompatible || linodeIsCloudInitCompatible);

const isEdgeRegionSelected = Boolean(
flags.gecko &&
flags.gecko2?.enabled &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to ensure anything touching create is tracked for the refactor work

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for addressing the changes 🚒

@hana-linode hana-linode merged commit 70106ac into linode:develop Apr 11, 2024
17 of 18 checks passed
@hana-linode hana-linode deleted the M3-7959-update-gecko-feature-flag branch April 11, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gecko GA Relating to Gecko GA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants