-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-7959] - Update gecko feature flag to object #10363
feat: [M3-7959] - Update gecko feature flag to object #10363
Conversation
Coverage Report: β |
packages/manager/src/components/SelectRegionPanel/SelectRegionPanel.tsx
Outdated
Show resolved
Hide resolved
@@ -474,7 +474,7 @@ export class LinodeCreate extends React.PureComponent< | |||
(imageIsCloudInitCompatible || linodeIsCloudInitCompatible); | |||
|
|||
const isEdgeRegionSelected = Boolean( | |||
flags.gecko && | |||
flags.gecko2?.enabled && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just need to ensure anything touching create is tracked for the refactor work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for addressing the changes π’
Description π
Update the gecko feature flag from a boolean to an object so we can have more granular control for Beta/GA
Changes π
gecko2
object feature flag overgecko
feature flagPreview π·
How to test π§ͺ
Prerequisites
Verification steps
Note: You may need to click
reset to LD defaults flags
in dev tools after each variation switch to see the changesAs an Author I have considered π€
Check all that apply