Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [M3-7770] - isFeatureEnabledV2 to check for feature flag AND account capability #10371

Merged
merged 5 commits into from
Apr 16, 2024
Merged

refactor: [M3-7770] - isFeatureEnabledV2 to check for feature flag AND account capability #10371

merged 5 commits into from
Apr 16, 2024

Conversation

hana-linode
Copy link
Contributor

@hana-linode hana-linode commented Apr 11, 2024 •
edited

Description 📝

Deprecate isFeatureEnabled function and add new function isFeatureEnabledV2 which uses AND logic instead of OR

Preview 📷

Capabilities On Capabilities Off
LD Feature Flag On Show feature: YES Show feature: NO
LD Feature Flag Off Show feature: NO Show feature: NO

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hana-linode hana-linode self-assigned this Apr 11, 2024
@hana-linode hana-linode changed the title refactor: [M3-7770] - isFeatureEnabled to check for feature flag AND account capability refactor: [M3-7770] - isFeatureEnabledV2 to check for feature flag AND account capability Apr 15, 2024
@hana-linode hana-linode marked this pull request as ready for review April 15, 2024 16:57
@hana-linode hana-linode requested a review from a team as a code owner April 15, 2024 16:57
@hana-linode hana-linode requested review from mjac0bs and jaalah-akamai and removed request for a team April 15, 2024 16:57
cpathipa
cpathipa approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hana-linode hana-linode added the Add'tl Approval Needed Waiting on another approval! label Apr 15, 2024
bnussman-akamai
bnussman-akamai reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a "v2 function" sounds good to me 👍

While we probably don't need it, we might want to add some unit tests

packages/manager/src/utilities/accountCapabilities.ts Outdated Show resolved Hide resolved
mjac0bs
mjac0bs approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending Banks' suggested changes are made, and I had a couple optional suggestions for clarity, too.

packages/manager/src/utilities/accountCapabilities.ts Outdated Show resolved Hide resolved
packages/manager/.changeset/pr-10371-tech-stories-1713200214722.md Outdated Show resolved Hide resolved
packages/manager/src/utilities/accountCapabilities.ts Outdated Show resolved Hide resolved
@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Apr 16, 2024
@github-actions GitHub Actions
Copy link

Coverage Report: ✅
Base Coverage: 81.79%
Current Coverage: 81.8%

@hana-linode hana-linode merged commit 2a2aa25 into linode:develop Apr 16, 2024
18 checks passed
@hana-linode hana-linode deleted the M3-7770-is-feature-enabled branch April 16, 2024 17:36
mjac0bs pushed a commit to mjac0bs/manager that referenced this pull request Apr 18, 2024
@hana-linode @mjac0bs
refactor: [M3-7770] - isFeatureEnabledV2 to check for feature flag AN…
2b958c2 
…D account capability (linode#10371)

## Description 📝
Deprecate `isFeatureEnabled` function and add new function `isFeatureEnabledV2` which uses AND logic instead of OR

## Preview 📷
|  | Capabilities On   | Capabilities Off |
| ------- | ------- | ------- |
| LD Feature Flag On | Show feature: YES | Show feature: NO |
| LD Feature Flag Off | Show feature: NO | Show feature: NO |
This was referenced Apr 25, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnussman-akamai bnussman-akamai bnussman-akamai left review comments

@mjac0bs mjac0bs mjac0bs approved these changes

@cpathipa cpathipa cpathipa approved these changes

@jaalah-akamai jaalah-akamai Awaiting requested review from jaalah-akamai jaalah-akamai is a code owner automatically assigned from linode/frontend

Assignees

@hana-linode hana-linode

Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hana-linode @mjac0bs @bnussman-akamai @cpathipa