fix: [UIE-7601] - disable smaller plans #10381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpolotsk-akamai
requested review from
carrillo-erik and
cpathipa
and removed request for
a team
mpolotsk-akamai
force-pushed
the
feature/UIE-7601-disabled-smaller-plans-are-clickable
branch
2 times, most recently
from
31230aa
to
cfb49d4
Compare
|
Coverage Report: ✅ |
|
Changes look good and I was able to verify that other plans were not able to be selected as presented in the images below: Before
After
Only ask if you could please include a unit test for the changes and to meet the Base Coverage criteria. Good Job. |
carrillo-erik
requested changes
Apr 17, 2024
mpolotsk-akamai
force-pushed
the
feature/UIE-7601-disabled-smaller-plans-are-clickable
branch
from
cfb49d4
to
ab1968c
Compare
mpolotsk-akamai
force-pushed
the
feature/UIE-7601-disabled-smaller-plans-are-clickable
branch
from
ab1968c
to
e7f26c7
Compare
bnussman-akamai
approved these changes
Apr 19, 2024
|
Changes look good. The e2e failures in |
|
Thank you @bnussman-akamai |
carrillo-erik
approved these changes
Apr 22, 2024
|
Thank you @carrillo-erik |
cpathipa
approved these changes
Apr 22, 2024
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixing issue with clickable disabled smaller plans in Resizing Tab
Target release date 🗓️
Release date: 04/29/2024
How to test 🧪
Open application, navigate to /databases, select the database cluster. Go to Resize tab, and click on one of the disabled plan. Summary section remains unchanged. 'Resize Database Cluster' button is disabled.
As an Author I have considered 🤔
Check all that apply