-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-7688] - Gravatar Analytics #10389
change: [M3-7688] - Gravatar Analytics #10389
Conversation
Coverage Report: β |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! confirmed events are being sent. β
i could see:
{
"action": "Load",
"category": "Gravatar",
"label": "Has Gravatar"
"value": true
}
{
"action": "Load",
"category": "Gravatar",
"label": "Has Gravatar"
"value": false
}
for payloads, but i guess it reporting ends up the same that's prob fine
clearInterval(interval); | ||
} | ||
}, 1000); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet! now we can re-use this as needed
looks good, concise and leakage proof π
We could use a boolean here with the new |
I'm a bit confused. Why did @abailly-akamai see |
@bnussman-akamai I read "see" as "imagine", not like physically see. π |
@bnussman-akamai @mjac0bs is correct. I was envisionning such payload as a more logical one - thx for the clarification however! is value typed that way by us? is it required to be typed as such by the script? |
OHHH. My fault, I understand now π€¦ haha So are we cool with using |
am cool with that but in the future i would love to use the value field if we can control its type. not a big deal we could event use 0/1 to represent booleans if we can't, tho i am not sure that would be an improvement |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the events are firing as expected. One thing I guess we'll have to take into account when looking at this data is that page refreshes for a user will send another Has Gravatar/Does not have Gravatar event. I know we can measure the number of unique visitors, and what I think we'd really want to do in Adobe is look at the unique visitors this event is firing for.
Thank you for doing this - I'm glad we're finally collecting data!
ah i see - thx @mjac0bs!
for sure - the user info is passed along, right? |
I think so, but tbh I don't know all of the variables in Adobe Analytics or the correct way to graph it in a dash. I'll follow up with Laura and/or Richa on this. |
I am also curious about that. I feel like the data could be skewed. For example, if users with Gravatars load Cloud Manager more often, more "Has Gravatar" events will be captured. This data won't be representative of the actual percentage of users that have Gravatars setup vs not setup because it is just based on page loads as far as I have it setup. @mjac0bs @abailly-akamai |
I actually want to retract my previous statement because I think we can't send any user information (event an userId) to 3rd party service without authorization. With that being said, we have a couple options:
|
@abailly-akamai Yeah, I see Unique Visitors in Adobe. I don't understand how to correctly graph that against component type (custom click events) because the numbers don't look right. I did reach out to Laura to let her know we're working on this again and see if she knows the correct way to chart this. |
@mjac0bs Want me to go ahead and merge or hold off? |
Let's hold until I hear back from Laura just to make sure we will be able to get what we want out of this. I'll keep you posted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming Gravatar
events are firing as expected.
@bnussman-akamai We've got two solid days of stats that make sense. I'm removing the |
Description π
Manage photo
on the Profile Display page (http://localhost:3000/profile/display
)How to test π§ͺ
Prerequisites
window._satellite.setDebug(true)
in your browser consoleVerification steps
Manage Photo
on thehttp://localhost:3000/profile/display
pageAs an Author I have considered π€