fix: Update latest kernel version to fix linode-config.spec.ts
#10391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
cliu-akamai
and removed request for
a team
bnussman-akamai
added
the
e2e
bnussman-akamai
changed the title
linode-config.spec.tslinode-config.spec.ts
bnussman-akamai
commented
Apr 19, 2024
| @@ -110,7 +110,7 @@ describe('Linode Config', () => { | |||
| cy.findByLabelText('List of Configurations').within(() => { | |||
| cy.get('tr').should('have.length', 2); | |||
| containsVisible( | |||
| `${linode.id}-test-config – Latest 64 bit (6.2.9-x86_64-linode160)` | |||
| `${linode.id}-test-config – Latest 64 bit (6.7.9-x86_64-linode163)` | |||
There was a problem hiding this comment.
I wonder if we should update this assertion to not test for the exact version 🤔 I'm not sure how frequently new kernels get published by Linode, but I assume it could happen at any time or frequency
Suggested change
| `${linode.id}-test-config – Latest 64 bit (6.7.9-x86_64-linode163)` | |
| `${linode.id}-test-config – Latest 64 bit` |
I just went for the easy fix for now. @jdamore-linode might have some insight or opinions here
bnussman-akamai
requested review from
mjac0bs and
hkhalil-akamai
and removed request for
a team
|
Coverage Report: ✅ |
mjac0bs
approved these changes
Apr 19, 2024
alioso
approved these changes
Apr 19, 2024
|
@abailly-akamai We need the other version of you! |
cpathipa
approved these changes
Apr 19, 2024
|
Here i am! too late! |
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
linode-config.spec.tsfailures ❌How to test 🧪
linode-config.spec.tspasses in Jenkins ✅linode-config.spec.tspasses locally (optional) ✅As an Author I have considered 🤔