Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [M3-8004] – Support LDE feature flag #10402

Merged
merged 3 commits into from
Apr 24, 2024
Merged

feat: [M3-8004] – Support LDE feature flag #10402

merged 3 commits into from
Apr 24, 2024

Conversation

dwiley-akamai
Copy link
Contributor

Description 📝

Create a boolean feature flag for LDE and support it in Cloud

Changes 🔄

  • LDE feature flag toggle added to our dev tool

Target release date 🗓️

4/29 or 5/13

How to test 🧪

Verification steps

  • Confirm a toggle for "Linode Disk Encryption (LDE)" is present in our dev tool

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@dwiley-akamai dwiley-akamai added the Linode Disk Encryption (LDE) Relating to LDE project label Apr 24, 2024
@dwiley-akamai dwiley-akamai self-assigned this Apr 24, 2024
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner April 24, 2024 16:55
@dwiley-akamai dwiley-akamai requested review from mjac0bs and abailly-akamai and removed request for a team April 24, 2024 16:55
dwiley-akamai
dwiley-akamai commented Apr 24, 2024
View reviewed changes
packages/manager/src/dev-tools/FeatureFlagTool.tsx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added LDE to the array and sorted it alphabetically

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼✨

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited

Coverage Report: ✅
Base Coverage: 81.86%
Current Coverage: 81.86%

mjac0bs
mjac0bs approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed I see the flag and a corresponding flag serving off is present in LD.

image

packages/manager/.changeset/pr-10402-upcoming-features-1713977776805.md Outdated Show resolved Hide resolved
packages/manager/src/dev-tools/FeatureFlagTool.tsx Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼✨

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Apr 24, 2024
@dwiley-akamai @mjac0bs
Update packages/manager/.changeset/pr-10402-upcoming-features-1713977…
2e90a3b 
…776805.md

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Apr 24, 2024
@dwiley-akamai dwiley-akamai merged commit e6ab3fc into linode:develop Apr 24, 2024
18 checks passed
@dwiley-akamai dwiley-akamai deleted the M3-8004-lde-feature-flag branch April 24, 2024 21:17
This was referenced Apr 25, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjac0bs mjac0bs mjac0bs approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@abailly-akamai abailly-akamai Awaiting requested review from abailly-akamai abailly-akamai is a code owner automatically assigned from linode/frontend

Assignees

@dwiley-akamai dwiley-akamai

Labels
Approved Multiple approvals and ready to merge! Linode Disk Encryption (LDE) Relating to LDE project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dwiley-akamai @mjac0bs @bnussman-akamai @DevDW