hotfix: Use 'edge'-class plans for edge regions #10441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkhalil-akamai
added
Hotfix
hkhalil-akamai
requested review from
mjac0bs,
bnussman-akamai and
hana-linode
and removed request for
a team
bnussman-akamai
previously approved these changes
May 6, 2024
mjac0bs
previously approved these changes
May 6, 2024
There was a problem hiding this comment.
✅ Verified only edge regions are displayed when selected, once the account has the necessary edge tags.
I didn't review this PR the first time around so I'm lacking some context, but I'm assuming we're keeping the Summary panel using $0 pricing, rather than displaying the prices returned by the edge types, until the beta period ends?
mjac0bs
reviewed
May 6, 2024
There was a problem hiding this comment.
I think we'd update the API and Manager changelogs directly rather than add a changeset. And include the package version bumps in this PR.
jaalah-akamai
previously approved these changes
May 6, 2024
hana-linode
previously approved these changes
May 6, 2024
hkhalil-akamai
dismissed stale reviews from hana-linode, jaalah-akamai, mjac0bs, and bnussman-akamai
via
ba0fc75
abailly-akamai
previously approved these changes
May 6, 2024
mjac0bs
previously approved these changes
May 6, 2024
hana-linode
previously approved these changes
May 6, 2024
hkhalil-akamai
dismissed stale reviews from hana-linode, mjac0bs, and abailly-akamai
via
4782907
abailly-akamai
approved these changes
May 6, 2024
mjac0bs
approved these changes
May 6, 2024
hkhalil-akamai
force-pushed
the
api-edge-plans-release
branch
from
4782907
to
cab31d9
Compare
bnussman-akamai
approved these changes
May 6, 2024
hana-linode
approved these changes
May 6, 2024
|
Coverage Report: ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is a reimplementation of #10415 built off of staging. I am copying the description from that PR.
Description 📝
Updates the logic in
PlansPanelto display plans with the new 'edge' class when deploying a Linode in an edge region.Target release date 🗓️
ASAP (out of cycle)
Preview 📷
How to test 🧪
Prerequisites
edge_computeandedge_testingcustomer tags.Verification steps
As an Author I have considered 🤔
Check all that apply