Add: Longview Memory Gauge

[martinmckenna]

🚨 This code got a little muddy. I think in follow up PR, I'm going to add logic to the Gauge to say

if (value === 0 && max === 0) { max = 1 }

so that we end up with a full grey bar if the stat is actually sitting at 0. See this commit in the next upcoming PR 🚨

Description

Adds Longview Memory Gauge

Type of Change

• Non breaking change ('update', 'change')

Note to Reviewers

I tried deleting my swap disk and seeing the dataset that is returned from the Longview API. It appears that if you don't have a certain disk, the response will still return the same keys but just have a value of 0.

I also initialized all values as undefined so that value || 1 logic isn't applied when a value is actually 0.

[martinmckenna]

@johnwcallahan the maxUnit option wasn't working out correctly, so I went with this as a workaround. The problem I was seeing was that once the value reached 1GB, it was still returning MB.

[johnwcallahan]

maxUnit should cap the unit. So maxUnit: 'MB' should return the value up to MB, but never higher. Could you just not specify a unit here and use what it gives you back?

Here are the unit tests for that option. If there is a bug, could you write a failing test?

manager/packages/manager/src/utilities/unitConversions.test.ts

Line 75 in 8f1e025

it("doesn't return units higher than the specific max unit", () => {

[martinmckenna]

I wanted to use both MB and GB, so I set the unit as GB and I was still getting MB for memory >= 1GB

[johnwcallahan]

The unit option lets you explicitly specify a unit for the result. So specifying{ unit: 'GB' } should always give you GB. Here's a test that confirms:

manager/packages/manager/src/utilities/unitConversions.test.ts

Line 91 in 8f1e025

expect(

Was your input still in bytes (as it should always be)?

[martinmckenna]

I think I had { unit: 'MB', maxUnit: 'GB' }. I might have to retry this again.

[martinmckenna]

yep looking back on this, it seems like you can't use both maxUnit and unit at the same time. I think the solution I have in place should be fine.

[martinmckenna]

jestjs/jest#7287

This is supposed to show better error messaging when an async operation is not cleaned up.

[johnwcallahan]

maxUnit should cap the unit. So maxUnit: 'MB' should return the value up to MB, but never higher. Could you just not specify a unit here and use what it gives you back?

Here are the unit tests for that option. If there is a bug, could you write a failing test?

manager/packages/manager/src/utilities/unitConversions.test.ts

Line 75 in 8f1e025

it("doesn't return units higher than the specific max unit", () => {

[Jskobos]

I mentioned this in John's Storage PR, the same thing happens here too: if a gauge goes from Error state --> Empty state, the Error text in the innerText remains, while any non-empty states update appropriately.

[johnwcallahan]

yep looking back on this, it seems like you can't use both maxUnit and unit at the same time. I think the solution I have in place should be fine.

The solution you have is fine, but you shouldn't need to pass in both maxUnit and unit. By passing in { unit: 'MB' } you are explicitly stating you want the output in MB, and maxUnit doesn't do anything. This is a note to myself to clean up docs for this.