[DNM][experimental][WIP Yarn workspaces to help with Lerna #5665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made a cleaner version of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
with Lerna some yarn command do not work
I read this:
https://yarnpkg.com/blog/2017/08/02/introducing-workspaces/
https://doppelmutzi.github.io/monorepo-lerna-yarn-workspaces/
And tried to see if enabling Yarn workspace would help
Type of Change
change
Added this to /package.json
Yarn should not have to be configures as workspaces is enabled by default
After doing this, and rerunning
yarn installfrom the root everything works.It is compatible with lerna
After this i can run in manager and root and linode-js-sdk:
BUT
yarn install in packages/manager/ Still fails because of patch-packages.
Although supposedly it should support it :
ds300/patch-package#42
Note to Reviewers
DO NOT MERGE, we need to talk and see if we think this is useful