Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: OBJ and Managed Feature Flags #5785

Merged
merged 2 commits into from Nov 19, 2019

Conversation

martinmckenna
Copy link
Contributor

Description

Removes usage of all managed and OBJ feature flags

Type of Change

  • Non breaking change ('update', 'change')

@martinmckenna martinmckenna self-assigned this Nov 18, 2019
import { ApplicationState } from 'src/store';
import EnableObjectStorageModal from '../EnableObjectStorageModal';
import { confirmObjectStorage } from '../utilities';
import { MODES } from './AccessKeyLanding';

export type MODES = 'creating' | 'editing';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing a cirlcular dep - commit wasn't working otherwise

Copy link
Contributor

@johnwcallahan johnwcallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was very satisfying to review.

@martinmckenna martinmckenna merged commit 6753a8d into linode:develop Nov 19, 2019
johnwcallahan added a commit to johnwcallahan/manager that referenced this pull request Feb 27, 2020
We actually introduced handling for restricted users in linode#5640, but this was reversed by a regression in linode#5785.

Re-adding handling for restricted users is especially important for the upcoming promo.

I also adjusted padding and margins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants