Added infrastructure for lint checks via spotbugs.

linqs · Jul 4, 2021 · 35062c0 · 35062c0
1 parent 8f80c38
commit 35062c0
Show file tree

Hide file tree

Showing 7 changed files with 66 additions and 0 deletions.
diff --git a/.ci/spotbugs-exclude.xml b/.ci/spotbugs-exclude.xml
@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<FindBugsFilter
+            xmlns="https://github.com/spotbugs/filter/3.0.0"
+            xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+            xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
+
+    <Match>
+        <!-- Note that the reports we want to ignore occur in anynonymous classes, so we need a regex. -->
+        <Class name="~org.linqs.psl.application.learning.weight.maxlikelihood.MaxPiecewisePseudoLikelihood\$\d+" />
+        <Bug pattern="DMI_RANDOM_USED_ONLY_ONCE" />
+    </Match>
+
+    <Match>
+        <Class name="org.linqs.psl.application.learning.weight.search.bayesian.SquaredExpKernel" />
+        <Method name="kernel" />
+        <Bug pattern="RV_RETURN_VALUE_IGNORED_INFERRED" />
+    </Match>
+
+    <Match>
+        <Class name="org.linqs.psl.reasoner.term.MemoryVariableTermStore" />
+        <Method name="updateModelAtoms" />
+        <Bug pattern="WMI_WRONG_MAP_ITERATOR" />
+    </Match>
+
+    <Match>
+        <Class name="org.linqs.psl.util.RandUtils" />
+        <Bug pattern="DMI_RANDOM_USED_ONLY_ONCE" />
+    </Match>
+
+</FindBugsFilter>
diff --git a/pom.xml b/pom.xml
@@ -65,6 +65,7 @@
 
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <rootdir>${project.basedir}</rootdir>
     </properties>
 
     <dependencies>
@@ -127,6 +128,21 @@
                     </execution>
                 </executions>
             </plugin>
+            <plugin>
+                <groupId>com.github.spotbugs</groupId>
+                <artifactId>spotbugs-maven-plugin</artifactId>
+                <version>4.2.0</version>
+                <dependencies>
+                    <dependency>
+                        <groupId>com.github.spotbugs</groupId>
+                        <artifactId>spotbugs</artifactId>
+                        <version>4.2.3</version>
+                    </dependency>
+                </dependencies>
+                <configuration>
+                    <excludeFilterFile>${rootdir}/.ci/spotbugs-exclude.xml</excludeFilterFile>
+                </configuration>
+            </plugin>
         </plugins>
     </build>
 

diff --git a/psl-cli/pom.xml b/psl-cli/pom.xml
@@ -29,6 +29,10 @@
         <version>2.3.0-SNAPSHOT</version>
     </parent>
 
+    <properties>
+        <rootdir>${project.basedir}/..</rootdir>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>org.linqs</groupId>

diff --git a/psl-core/pom.xml b/psl-core/pom.xml
@@ -29,6 +29,10 @@
         <version>2.3.0-SNAPSHOT</version>
     </parent>
 
+    <properties>
+        <rootdir>${project.basedir}/..</rootdir>
+    </properties>
+
     <dependencies>
         <!-- linear algebra dependencies -->
         <dependency>

diff --git a/psl-java/pom.xml b/psl-java/pom.xml
@@ -29,6 +29,10 @@
         <version>2.3.0-SNAPSHOT</version>
     </parent>
 
+    <properties>
+        <rootdir>${project.basedir}/..</rootdir>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>org.linqs</groupId>

diff --git a/psl-parser/pom.xml b/psl-parser/pom.xml
@@ -30,6 +30,10 @@
         <version>2.3.0-SNAPSHOT</version>
     </parent>
 
+    <properties>
+        <rootdir>${project.basedir}/..</rootdir>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>org.linqs</groupId>

diff --git a/psl-python/pom.xml b/psl-python/pom.xml
@@ -30,6 +30,10 @@
         <version>2.3.0-SNAPSHOT</version>
     </parent>
 
+    <properties>
+        <rootdir>${project.basedir}/..</rootdir>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>org.linqs</groupId>