Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(previewer): respect 'number' options #690

Merged
merged 3 commits into from
May 6, 2024

Conversation

linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented May 6, 2024

Resolve #684 .

Regresion test

Platforms

  • windows
  • macOS
  • linux

Tasks

  • FzfxFiles
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Press CTRL-U/CTRL-R to switch between restricted/unrestricted mode, and the lines count is consistent when press multiple times.
    • Use V/W/P/R variants (visual selection, cursor word, yank text, resume last).
    • Press ESC to quit, ENTER to open file, and open the test/hello world.txt, test/goodbye world/goodbye.lua files.
    • Both fd and find works.
  • FzfxLiveGrep
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Press CTRL-U/CTRL-R to switch between restricted/unrestricted mode, and the lines count is consistent when press multiple times.
    • Use -w to match word only, use -g *.lua to search only lua files.
    • Use V/W/P/R variants (visual selection, cursor word, yank text, resume last).
    • Press ESC to quit, ENTER to open file, and open the test/hello world.txt, test/goodbye world/goodbye.lua files.
    • Both rg and grep works.
  • FzfxBufLiveGrep
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Use -w to match word only, use -g *.lua to search only lua files.
    • Use V/W/P/R variants (visual selection, cursor word, yank text, resume last).
    • Press ESC to quit, ENTER to open file.
    • Both rg and grep works.
  • FzfxBuffers
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Press CTRL-D to delete buffers, and delete the test/hello world.txt, test/goodbye world/goodbye.lua buffers.
    • Use V/W/P/R variants (visual selection, cursor word, yank text, resume last).
    • Press ESC to quit, ENTER to open file.
  • FzfxGFiles
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Press CTRL-U/CTRL-W to switch between workspace/current folder mode.
    • Use V/W/P/R variants (visual selection, cursor word, yank text, resume last).
    • Press ESC to quit, ENTER to open file.
  • FzfxGLiveGrep
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Use V/W/P/R variants (visual selection, cursor word, yank text, resume last).
    • Press ESC to quit, ENTER to open file.
  • FzfxGStatus
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Press CTRL-U/CTRL-W to switch between workspace/current folder mode.
    • Use V/W/P/R variants (visual selection, cursor word, yank text, resume last).
    • Press ESC to quit, ENTER to open file.
    • Both with/without delta works.
  • FzfxGBranches
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Press CTRL-R/CTRL-O to switch between local/remote branches.
    • Use V/W/P/R variants (visual selection, cursor word, yank text, resume last).
    • Press ESC to quit, ENTER to checkout branch.
  • FzfxGCommits
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Press CTRL-U/CTRL-A to switch between git repo commits/current buffer commits.
    • Use V/W/P/R variants (visual selection, cursor word, yank text, resume last).
    • Press ESC to quit, ENTER to copy commit hash.
    • Both with/without delta works.
  • FzfxGBlame
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Use V/W/P/R variants (visual selection, cursor word, yank text, resume last).
    • Press ESC to quit, ENTER to copy commit hash.
    • Both with/without delta works.
  • FzfxLspDiagnostics
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Press CTRL-U/CTRL-W to switch between workspace/current buffer diagnostics.
    • Use V/W/P/R variants (visual selection, cursor word, yank text, resume last).
    • Press ESC to quit, ENTER to open file.
  • FzfxLspDefinitions, FzfxLspTypeDefinitions, FzfxLspReferences, FzfxLspImplementations
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Go to definitions/references (this is the most 2 easiest use case when developing this lua plugin with lua_ls).
    • Press ESC to quit, ENTER to open file.
  • FzfxLspIncomingCalls, FzfxLspOutgoingCalls
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Go to incoming/outgoing calls.
    • Press ESC to quit, ENTER to open file.
  • FzfxCommands
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Press CTRL-U/CTRL-E/CTRL-A to switch between user/ex/all vim commands.
    • Use V/W/P/R variants (visual selection, cursor word, yank text, resume last).
    • Press ESC to quit, ENTER to feed vim command.
  • FzfxKeyMaps
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Press CTRL-O/CTRL-I/CTRL-A/CTRL-V to switch between normal/insert/visual/all vim key mappings.
    • Use V/W/P/R variants (visual selection, cursor word, yank text, resume last).
    • Press ESC to quit, ENTER to feed vim keys.
  • FzfxMarks
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Use V/W/P/R variants (visual selection, cursor word, yank text, resume last).
    • Press ESC to quit, ENTER to open file.
  • FzfxFileExplorer
    • Press CTRL-J/CTRL-K to move down/up and preview contents.
    • Press CTRL-U/CTRL-R to switch between filter/include hidden files mode.
    • Press ALT-L/ALT-H to cd into folder and cd upper folder.
    • Use V/W/P/R variants (visual selection, cursor word, yank text, resume last).
    • Press ESC to quit, ENTER to open file, and open the test/hello world.txt, test/goodbye world/goodbye.lua files.
    • All eza/lsd/ls works.

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 79.01%. Comparing base (1e040eb) to head (23bf01a).

Files Patch % Lines
lua/fzfx/detail/popup/buffer_popup_window.lua 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
- Coverage   79.02%   79.01%   -0.01%     
==========================================
  Files          53       53              
  Lines        6307     6309       +2     
==========================================
+ Hits         4984     4985       +1     
- Misses       1323     1324       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linrongbin16 linrongbin16 merged commit e502269 into main May 6, 2024
9 checks passed
@linrongbin16 linrongbin16 deleted the previewer-column-settings branch May 6, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disabling the signcolumn and line numbers in pop-up window
1 participant