Fix setting brightness to max value and brightness fading loop condition #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Martin-HiPi
commented
Jul 14, 2021
Martin-HiPi
commented
- Function _denormalize_brightness does not clamp the output to the normal 0-255 int() range. Force-clamped 0-255 now.
- Function _normalize_brightness does not clamp the output to the normal 0-100 percent range. Force-clamped 0-100 now.
- In @brightness.setter, the while loop looks only for current_value != value. In some circumstances, it won't stop incrementing. Hard-clamped to 0-100 percent range.
- Function _denormalize_brightness does not clamp the output to the normal 0-255 int() range. Force-clamped 0-255 now. - Function _normalize_brightness does not clamp the output to the normal 0-100 percent range. Force-clamped 0-100 now. - In @brightness.setter, the while loop looks only for current_value != value. In some circumstances, it won't stop incrementing. Hard-clamped to 0-100 percent range.
linusg
requested changes
Jul 14, 2021
|
Thanks @linusg for taking the time to review the PR. I'm not too familiar with the black formatting part, anything you can point me to? |
|
I used what showed in the logs to re-write the while conditions.
|
@linusg Thanks for the info! |
Fixed one missing space in def _normalize_brightness that caused the black formatting check to fail.
Two lines had spaces at the end. These are obviously invisible in black logs unless you actively search for them!
linusg
changed the title
|
Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.