Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pam_dynamic.c:79 syntax error #477

Closed
AndrewChe7 opened this issue Jul 15, 2022 · 1 comment · Fixed by #521
Closed

pam_dynamic.c:79 syntax error #477

AndrewChe7 opened this issue Jul 15, 2022 · 1 comment · Fixed by #521

Comments

@AndrewChe7
Copy link

I found syntax error with cppcheck in 79 and 85 line of file libpam/pam_dynamic.c. Unmatched '(':

if( shl_findsym(&handle, symbol, (short) TYPE_PROCEDURE, &ret ){
		_symbol = malloc( strlen(symbol) + sizeof(SHLIB_SYM_PREFIX) + 1 );
...
if( shl_findsym(&handle, _symbol,
				(short) TYPE_PROCEDURE, &ret ){

Seems like this code is never used, cause I didn't found any PAM_DYDL or PAM_SHL definition. Maybe there is no need in these part of code or syntax error should be fixed.

@ldv-alt
Copy link
Member

ldv-alt commented Jul 15, 2022

@thkukuk Thorsten, you introduced that code by commit 8da7a65 back in 2005, at least the PAM_SHL variant cannot be compiled since that commit, and another variant uses PAM_DYLD which is virtually unknown to google search. Is that code dead?

ldv-alt added a commit that referenced this issue Jan 23, 2023
Apparently, the PAM_SHL variant cannot be compiled since the very first
commit back in 2005 when it was introduced, and another variant uses
PAM_DYLD which is virtually unknown to search engines.

* libpam/pam_dynamic.c [PAM_SHL || PAM_DYLD]: Remove.

Resolves: #477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants