Skip to content

Commit

Permalink
Fix shared library filenames
Browse files Browse the repository at this point in the history
We expect the filename to reflect the symbol versions in the file,
this means, eg libibverbs1.3 should have the IBVERBS_1.3 as the newest
symbol. The same applies to all libraries.

verbs was not updated in commit 3ca7a10 when new symbols were added

umad/rdmacm probably legitimately had a '.1' someday, but failed to
follow symver convention. Bump it back down.

Since distros are not using it in packaging the shared library version
and filename is no longer used by anything. We simply want it to follow
our own internal conventions.

Fixes: 3ca7a10 ("ibverbs: Add support for packet pacing")
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
  • Loading branch information
jgunthorpe committed Feb 1, 2017
1 parent 68f5605 commit 232796a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion libibumad/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ publish_headers(infiniband

rdma_library(ibumad libibumad.map
# See Documentation/versioning.md
3 3.1.${PACKAGE_VERSION}
3 3.0.${PACKAGE_VERSION}
sysfs.c
umad.c
umad_str.c
Expand Down
2 changes: 1 addition & 1 deletion libibverbs/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ endif()

rdma_library(ibverbs libibverbs.map
# See Documentation/versioning.md
1 1.3.${PACKAGE_VERSION}
1 1.4.${PACKAGE_VERSION}
cmd.c
compat-1_0.c
device.c
Expand Down
2 changes: 1 addition & 1 deletion librdmacm/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ publish_headers(infiniband

rdma_library(rdmacm librdmacm.map
# See Documentation/versioning.md
1 1.1.${PACKAGE_VERSION}
1 1.0.${PACKAGE_VERSION}
acm.c
addrinfo.c
cma.c
Expand Down

0 comments on commit 232796a

Please sign in to comment.