-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: Add barriers support for LoongArch #1035
Conversation
util/udma_barrier.h
Outdated
@@ -96,6 +96,8 @@ | |||
#define udma_to_device_barrier() asm volatile("dsb st" ::: "memory"); | |||
#elif defined(__sparc__) || defined(__s390x__) | |||
#define udma_to_device_barrier() asm volatile("" ::: "memory") | |||
#elif defined(__loongarch__) | |||
#define udma_to_device_barrier() asm volatile("dbar 0" ::: "memory"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh-oh. The macros should not have trailing semicolon in its expansion; this was neglected in previous reviews but got caught by upstream CI. You should remove the semicolons like in the previous block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed, thanks.
|
Add barriers support for LoongArch architecture Signed-off-by: wangguofeng <wangguofeng@loongson.cn> Reviewed-by: WANG Xuerui <git@xen0n.name> Reviewed-by: Na Zhang <zhangna@loongson.cn> Reviewed-by: Yaliang Zhu <zhuyaliang@loongson.cn>
thanks.
May not work. |
It is far from "may not work". I didn't hear from anyone that he/she used RDMA stack on MIPS arch. So the question is what HW that part of rdma-core and upstream kernel really works on MIPS? |
LoongArch is not MIPS, it is a new RISC architecture(such as aarch64, riscv). Here is some information about LoongArch.
We have the Mellanox ib cards. We need its some benchmark data. Users will also use it in the future. The card info as follow:
Our kernel(development version) already supported mlx4_ib.ko. We also need some other userspaces software, such as ib_write_bw, ib_send_bw and so on. These software need libmlx4.so, librdmacm.so, libibumad.so.3, libibverbs.so, etc. Compile libmlx4.so needs that adding barriers support for LoongArch architecture. Because of
Mlx4 does also need barrier support in LoongArch architecture. We've also got the benchmark data on Mellanox ib cards. |
Ohh, great. I read about it https://www.tomshardware.com/news/loongson-technology-develops-its-own-cpu-instruction-set-architecture and they talked about MIPS |
Add barriers support for LoongArch architecture(a new RISC architecture).