tests: Add tests for various error flows #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardSro
suggested changes
Jan 4, 2022
| @@ -31,6 +31,23 @@ def create_players(self, send_ops_flags=0, qp_count=8): | |||
| self.client.pre_run(self.server.psns, self.server.qps_num) | |||
| self.server.pre_run(self.client.psns, self.client.qps_num) | |||
|
|
|||
| def full_sq_bad_flow(self): | |||
There was a problem hiding this comment.
Is there a reason why you chose to skip UD in this case?
There was a problem hiding this comment.
UD is implemented by different providers. I don't think all of them return in an error in this manner and I don't want to break them.
PyverbsRDMAErrno is using errno as the error code, this is a problem where the error code is meaningful and can be checked. Moreover, errno is not meaningful in these situations. Reviewed-by: Chen Brasch <cbrasch@amazon.com> Reviewed-by: Yossi Leybovich <sleybo@amazon.com> Signed-off-by: Yonatan Nachum <ynachum@amazon.com> Signed-off-by: Firas Jahjah <firasj@amazon.com>
…et state Add generic error flow tests to check post receive/send while QP is in reset state, which is an invalid state for traffic. Add instances of the tests in UD and SRD. Reviewed-by: Chen Brasch <cbrasch@amazon.com> Signed-off-by: Yonatan Nachum <ynachum@amazon.com> Signed-off-by: Firas Jahjah <firasj@amazon.com>
Add generic error flow tests to check traffic in full RQ in QP. Add instances of the tests in UD and SRD. Reviewed-by: Chen Brasch <cbrasch@amazon.com> Signed-off-by: Yonatan Nachum <ynachum@amazon.com> Signed-off-by: Firas Jahjah <firasj@amazon.com>
Add SRD error flow test to check traffic in full SQ in QP. Reviewed-by: Chen Brasch <cbrasch@amazon.com> Signed-off-by: Yonatan Nachum <ynachum@amazon.com> Signed-off-by: Firas Jahjah <firasj@amazon.com>
Add generic error flow test to check post receive with RWR that have more than allowed SG entries. Add instances of the test in UD and SRD. Reviewed-by: Chen Brasch <cbrasch@amazon.com> Signed-off-by: Yonatan Nachum <ynachum@amazon.com> Signed-off-by: Firas Jahjah <firasj@amazon.com>
firasj
commented
Jan 19, 2022
| @@ -31,6 +31,23 @@ def create_players(self, send_ops_flags=0, qp_count=8): | |||
| self.client.pre_run(self.server.psns, self.server.qps_num) | |||
| self.server.pre_run(self.client.psns, self.client.qps_num) | |||
|
|
|||
| def full_sq_bad_flow(self): | |||
There was a problem hiding this comment.
UD is implemented by different providers. I don't think all of them return in an error in this manner and I don't want to break them.
EdwardSro
approved these changes
Feb 1, 2022
|
Kind reminder. |
|
Thanks for the reminder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series adds various error flow tests on post send/receive operations, and adds instances of these tests for UD and SRD.