libibverbs: consistently parse environment variables in ibverbs_init #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashikakheria
approved these changes
Jan 28, 2022
wzamazon
reviewed
Jan 28, 2022
jgunthorpe
requested changes
Jan 28, 2022
nzmsv
force-pushed
the
master
branch
3 times, most recently
from
7657063
to
e8f803b
Compare
rleon
reviewed
Jan 30, 2022
Prior to this change, setting some of the variables to "0" would be confusingly interpreted as enabling the feature. Signed-off-by: Greg Inozemtsev <ginozemt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, setting some of the variables to "0" would be confusingly interpreted as enabling the feature.