mlx5: Handle the EREMOTEIO upon DEVX usage #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some variables cause compilation warnings, as the compiler doesn't recognize their initialization. Explicitly initialize them to avoid the warnings. Signed-off-by: Aharon Landau <aharonl@nvidia.com> Reviewed-by: Avihai Horon <avihaih@nvidia.com> Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
When a DEVX command is executed by FW and failed, EREMOTEIO is returned to indicate the caller that the command status and syndrome are available in the outbox. Add this info to the DEVX man pages. Signed-off-by: Aharon Landau <aharonl@nvidia.com> Reviewed-by: Avihai Horon <avihaih@nvidia.com> Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
…ally Some functions make use of DEVX commands internally and don't expose the outbox to the caller, so the caller will get an obscure EREMOTEIO in such cases. In those cases, translate the outbox error status internally and return it to the caller. Signed-off-by: Aharon Landau <aharonl@nvidia.com> Reviewed-by: Avihai Horon <avihaih@nvidia.com> Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
The following [1] kernel series changed the command interface return codes for DEVX commands. In regular (non-VFIO) DEVX APIs, if the command was executed by FW but outbox.status != MLX5_CMD_STAT_OK, EREMOTEIO is returned to indicate to the caller that the command status and syndrome are available in the outbox. Change VFIO DEVX APIs return codes to be aligned with that according to the updated man pages. [1] https://lore.kernel.org/netdev/20220223050932.244668-1-saeed@kernel.org/. Signed-off-by: Aharon Landau <aharonl@nvidia.com> Reviewed-by: Avihai Horon <avihaih@nvidia.com> Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series handles the EREMOTEIO return code upon DEVX usage.
When a DEVX command is executed by FW and failed, EREMOTEIO is returned to indicate the caller that the command status and syndrome are available in the outbox.