tests: ODP testcases for RDMA Write/Read and Atomic operations #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ODP test imports multiple objects from test.utils module. Make it simple by importing the whole module just as majority of other tests do. Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
ODP test is using a syntax different from most other traffic tests. A large portion of them treat 'client' and 'server' as class members and use 'traffic_args' as an argument for each test case. Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
Add tests that use Atomic operations with ODP. They use the same workload as 'compare-and-swap' and 'fetch-and-add' in "test_atomic.py". Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
ddmatsu
force-pushed
the
odp_testcases
branch
2 times, most recently
from
e9dd7fb
to
1ed3532
Compare
Add a test that uses RDMA Read operation with ODP. Writing to a MR on the server must precede for RDMA Read to succeed. Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
Add a test that uses RDMA Write operation with ODP. Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
ddmatsu
force-pushed
the
odp_testcases
branch
from
1ed3532
to
5183fdc
Compare
EdwardSro
approved these changes
Oct 23, 2022
|
Regarding ODP Atomic tests, I agree that the ODP CAPs are not reporting the Atomic support, even though it's supported. |
|
I believe this work is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches add new testcases for ODP (test_odp.py). Currently, only Send/Recv operations are checked, and other operations are not tested with ODP at all. This patchset cleans-up the ODP test code and add four new testcases. I confirmed these new testcases succeeded with RFC implementation of Explicit ODP on rxe[1].
The new testcases succeeded also with ConnectX-6, but currently the ODP Atomic tests are skipped with my device. This is because the capability for RC (rc_odp_caps) is not filled with IB_ODP_SUPPORT_ATOMIC in internal_fill_odp_caps(). However, it seems the device can actually handle Atomic operations. I am not sure if this is a bug of the device or not. If anybody from NVIDIA knows why rc_odp_caps is unfilled, please let me know
cf. https://github.com/torvalds/linux/blame/master/drivers/infiniband/hw/mlx5/odp.c#L321
The first two patches are for clean-up:
tests: Import test.utils entirely for ODP test cases
tests: Make ODP test consistent with other traffic tests
The latter three add new testcases:
tests: Add tests for Atomic operations with ODP
tests: Add a test for RDMA Read with ODP
tests: Add a test for RDMA Write with ODP
[1] [RFC PATCH 0/7] RDMA/rxe: On-Demand Paging on SoftRoCE
https://lore.kernel.org/lkml/cover.1662461897.git.matsuda-daisuke@fujitsu.com/t/