Debian packaging changes (from review) #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Debian packaging for rdma-core was derived from the individual source packages from the Debian project. Thus the copyright of the files in debian needs to be carried over. The debian directory in libibumad and libibcm was licensed under GPL-2+ by Genome Research Ltd. The debian directory in ibacm was licensed under GPL-2+ by Ana Beatriz Guerrero Lopez <ana@debian.org>. Jason Gunthorpe and Talat Batheesh agreed on relicensing their contribution to the debian directory under the GPL-2+. Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
The Debian packaging should be a thin layer around the upstream package and the upstream package should not know anything about the debian/ directory. Thus remove the copying of debian/srptools.init and debian/srptools.default from srp_daemon/CMakeLists.txt and let the Debian package handle the installation instead. Instead of shipping custom sysvinit scripts in Debian, upstream should provide sysvinit and systemd service files that can be used in Debian as well. An additional srp_daemon.sh shell script should not be necessary for it. Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
See Debian policy Priorities, Section 2.5: https://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
The synopsis (first line in the package "Description:" field, the short description) ends with a full stop "." character. This is not necessary, as the synopsis doesn't need to be a full sentence. It is recommended that a descriptive phrase is used instead. Note also that the synopsis is not part of the rest of the "Description:" field. Refer to Debian Developer's Reference section 6.2.2 (The package synopsis, or short description) for details. Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
Sort the list of binary packages in debian/control, but group libraries and their corresponding script/service packages together. Also move the overall rmda-core binary package to the top. Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
Lintian complains about a missing install key in the rdma-ndd.service, but this service is started by udev. Thus override the complain. Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
Upstream does not ship /etc/rsyslog.d/srp_daemon.conf any more. Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
ibverbs-providers uses the private symbols of libibverbs1. Thus libibverbs1 will not work with an old version version of ibverbs-providers if the private symbol version is bumped. Bump the ibverbs-providers version that libibverbs1 breaks which was forgotten on the symbol version bump. See also commit 611b7cc Signed-off-by: Benjamin Drung <benjamin.drung@profitbricks.com>
jgunthorpe
approved these changes
May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I continued the review on the combined source packages. See the individual commits for details. Please review them carefully and ask in case of questions.