Add RDMA write support to EFA provider #1317
Conversation
|
Where is the kernel side? |
|
Kernel side is dependent on data polling patch, will be glad to get reviews for both: thanks |
YonatanNachum
force-pushed
the
rdma_write
branch
from
f85d3d2
to
361b04f
Compare
|
This still seems like the kernel side hasn't been posted, I don't see it on patchworks. |
|
We've found another needed change, will sent kernel patch soon. |
YonatanNachum
force-pushed
the
rdma_write
branch
from
361b04f
to
f7eab7d
Compare
|
Thanks. |
|
This needs to be rebased |
Refactor send functions (messages and RDMA) to be more modular, add two new functions: set imm and set remote addr so send functions (messages and RDMA) can use those functions if needed. Signed-off-by: Yonatan Nachum <ynachum@amazon.com>
YonatanNachum
force-pushed
the
rdma_write
branch
2 times, most recently
from
7f2ff12
to
f866ad7
Compare
|
@jgunthorpe Thanks. |
To commit 531094dc7164 ("RDMA/efa: Add rdma write capability to device caps").
Signed-off-by: Yonatan Nachum <ynachum@amazon.com>
Add rdma write functions (with and without imm) to qp extended api and expose capability bit using query device direct verb. Signed-off-by: Yonatan Nachum <ynachum@amazon.com>
| @@ -76,6 +76,9 @@ struct efadv_device_attr { | |||
| Reading source address (SGID) from receive completion descriptors is supported. | |||
| Valid only for unknown AH. | |||
|
|
|||
| EFADV_DEVICE_ATTR_CAPS_RDMA_WRITE: | |||
| RDMA write is supported | |||
|
|
|||
| *max_rdma_size* | |||
There was a problem hiding this comment.
Does this apply to both RDMA read and write now?
There was a problem hiding this comment.
Hey,
No this does not apply for RDMA read. For RDMA read you must get also EFADV_DEVICE_ATTR_CAPS_RDMA_READ to know it is supported.
There was a problem hiding this comment.
I'm referring to max_rdma_size.
There was a problem hiding this comment.
Hey, sorry.
Yes, the max RDMA size is identical for read and write.
|
@jgunthorpe Thank you. |
EFA devices are now support RDMA write, make minor refactoring of EFA send inner function for creating wqe, set remote address and set immediate, and add RDMA write support.