libibverbs: ignore IBV_FORK_SAFE et.al. when kernel has fork support #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibv_fork_init will now check if IBV_FORK_UNNEEDED is true, and if so will skip initialization of mm_root. Environment variables like IBV_FORK_SAFE and UCX_IB_FORK_INIT are silently ignored when the kernel has the necessary fork support. Signed-off-by: Kevan Rehm <kevan.rehm@hpe.com>
|
@gal-pressman do you remember why we didn't do this from the start? |
|
In my case, it's not a question of performance improvement, it's a way to prevent segfaults when the user specifies an environment variable that enables ibv_fork_init. Background info available here. |
|
Then it is probably best to move forward like this |
|
Any issues moving forward with this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ibv_fork_init will now check if IBV_FORK_UNNEEDED is true, and if so will skip initialization of mm_root. Environment variables like IBV_FORK_SAFE and UCX_IB_FORK_INIT are silently ignored when the kernel has the necessary fork support.