Rdma core 13.10.16 list #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 13, 2016 10:41
Sparse complains about using plain integer as NULL pointer here, but I suspect we really want to check the value anyway, and Steve confirmed that's indeed the case. Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Steve Wise <swise@opengridcomputing.com> Signed-off-by: Leon Romanovsky <leon@kernel.org>
The only change in semantics is that we remove the entry from the list earlier in iwpm_pending_msgs_handler due to using the list_pop helper, but given that we won't exist the loop early ever this should not change behavior. Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Steve Wise <swise@opengridcomputing.com> Tested-by: Steve Wise <swise@opengridcomputing.com> Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com> Signed-off-by: Leon Romanovsky <leon@kernel.org>
Trivial conversion, nothing to see here. Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Steve Wise <swise@opengridcomputing.com> Tested-by: Steve Wise <swise@opengridcomputing.com> Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com> Signed-off-by: Leon Romanovsky <leon@kernel.org> ---- iwpmd/iwarp_pm.h | 5 ++--- iwpmd/iwarp_pm_helper.c | 14 +++----------- iwpmd/iwarp_pm_server.c | 11 ++++------- 3 files changed, 9 insertions(+), 21 deletions(-) Signed-off-by: Leon Romanovsky <leon@kernel.org>
Also ѕtop passing mappped_ports ports as an argument to some function and always use the global, which allows making mapped_ports static in iwarp_pm_helper.c. Now that no user of the iwpm_list infrastructure are left remove it. Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Steve Wise <swise@opengridcomputing.com> Tested-by: Steve Wise <swise@opengridcomputing.com> Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com> Signed-off-by: Leon Romanovsky <leon@kernel.org> ---- iwpmd/iwarp_pm.h | 26 ++++---------- iwpmd/iwarp_pm_helper.c | 92 +++++++++---------------------------------------- iwpmd/iwarp_pm_server.c | 27 +++++++-------- 3 files changed, 35 insertions(+), 110 deletions(-) Signed-off-by: Leon Romanovsky <leon@kernel.org>
jgunthorpe
pushed a commit
to jgunthorpe/rdma-plumbing
that referenced
this pull request
Feb 19, 2019
Update .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.