Generate and install pkgconfig files for the RDMA libraries #373

bluca · 2018-08-28T20:38:06Z

It's very useful for applications and other projects to be able to use pkgconfig to build with external libraries. Generate and install pc files for the three RDMA libraries.

Here's how the files look after a Debian build:

prefix=/usr
exec_prefix=${prefix}
libdir=${prefix}/lib/x86_64-linux-gnu
includedir=${prefix}/include

Name: libibverbs
Description: RDMA Core Userspace Library
Version: 20.0
Libs: -L${libdir} -libverbs
Libs.private: -lnl-route-3 -lnl-3 -lpthread
Cflags: -I${includedir} -I/usr/include/libnl3
Requires:

prefix=/usr
exec_prefix=${prefix}
libdir=${prefix}/lib/x86_64-linux-gnu
includedir=${prefix}/include

Name: librdmacm
Description: RDMA Core Userspace Library
Version: 20.0
Libs: -L${libdir} -lrdmacm
Libs.private:
Cflags: -I${includedir} 
Requires:

prefix=/usr
exec_prefix=${prefix}
libdir=${prefix}/lib/x86_64-linux-gnu
includedir=${prefix}/include

Name: libibumad
Description: RDMA Core Userspace Library
Version: 20.0
Libs: -L${libdir} -libumad
Libs.private: 
Cflags: -I${includedir} 
Requires: libibverbs

bdrung · 2018-08-29T09:40:30Z

These changes look good to me (haven't tested it).

rleon

Thanks for your PR

librdmacm/CMakeLists.txt

rleon · 2018-08-30T04:34:30Z

debian/control

@@ -127,6 +127,8 @@ Architecture: linux-any
 Multi-Arch: same
 Depends: ibverbs-providers (= ${binary:Version}),
         libibverbs1 (= ${binary:Version}),
+         libnl-3-dev,
+         libnl-route-3-dev,


rdma-core section has already this dependency,
Isn't this enough? sorry for my dumb question, I'm not debian guru.

Source: rdma-core
Maintainer: Linux RDMA Mailing List linux-rdma@vger.kernel.org
Uploaders: Benjamin Drung benjamin.drung@profitbricks.com,
Talat Batheesh talatb@mellanox.com
Section: net
Priority: optional
Build-Depends: cmake (>= 2.8.11),
debhelper (>= 9),
debhelper (>= 9.20160709) | dh-systemd,
dpkg-dev (>= 1.17),
libnl-3-dev,
libnl-route-3-dev,
libudev-dev,

Yes - in that section that's a build dependency for these packages. Here it's a runtime dependency of the dev library, and as the commit msg says it's needed if a third party wants to do static linking with ibverbs, as they'll need to install and static link to everything that ibverbs depends on, which in this case is nl3

No, this is wrong, we don't support static linking in Debian packaging today so don't need the -dev packages here. If we add static libraries someday it would become necessary.

The static library is built and shipped as you can see here:
https://packages.debian.org/buster/amd64/libibverbs-dev/filelist

packages.debian.org is not working, it is showing you a file list from a pre rdma-core package, our packaging does not enable static libraries. download the .deb from buster and check yourself with dpkg-deb -c.

Uh, hadn't noticed it was broken, interesting (and annoying). I'll revert this commit then, thanks for spotting it.

bluca · 2018-08-30T09:51:21Z

@rleon all done, thanks

rleon · 2018-08-30T17:31:45Z

One latest change, please fix title from "Genearate" to be "Generate" in this PR and in first commit too.

Add a template and generate a pc file for each shared library using CMake. Signed-off-by: Luca Boccassi <bluca@debian.org>

ibverbs uses NL3, which has to be present when doing statically linked builds, so add the dependencies on the libibverbs-dev library. Signed-off-by: Luca Boccassi <bluca@debian.org>

bluca · 2018-08-30T17:40:15Z

I always make that typo! @rleon fixed

rleon · 2018-08-31T16:15:05Z

Thanks

jgunthorpe · 2018-09-01T21:09:45Z

debian/control

@@ -127,6 +127,8 @@ Architecture: linux-any
 Multi-Arch: same
 Depends: ibverbs-providers (= ${binary:Version}),
         libibverbs1 (= ${binary:Version}),
+         libnl-3-dev,
+         libnl-route-3-dev,


No, this is wrong, we don't support static linking in Debian packaging today so don't need the -dev packages here. If we add static libraries someday it would become necessary.

jgunthorpe · 2018-09-01T21:10:33Z

debian/libibverbs-dev.install

@@ -13,6 +13,7 @@ usr/include/infiniband/verbs_api.h
 usr/lib/*/libibverbs*.so
 usr/lib/*/libmlx4.so
 usr/lib/*/libmlx5.so
+usr/lib/*/pkgconfig/libibverbs.pc


Where are the pkgconfigs for libmlx5 and 4?

They are not built for now. Where are those libs built from?

providers/mlx5 and providers/mlx4, they are intended as application linkable libraries and as provider plugins, eg dpdk links to them.

Ok, thanks, will add them too

jgunthorpe · 2018-09-01T21:11:23Z

buildlib/rdma_functions.cmake

+  set(PC_LIB_PRIVATE "${PC_LIB_PRIVATE}")
+  set(PC_INCLUDE_PRIVATE "${PC_INCLUDE_PRIVATE}")
+  set(PC_REQUIRES "${PC_REQUIRES}")
+  configure_file(${CMAKE_SOURCE_DIR}/buildlib/template.pc.in ${CMAKE_CURRENT_BINARY_DIR}/lib${PC_LIB_NAME}.pc @ONLY)


Don't we need a build/lib/pkgconfig/ as well specifying options to 'use in place' ?

Sorry, I'm not sure I follow? What do you mean?

rdma-core is designed to be built an run 'in-place' when the -DIN_PLACE=1 is used. It sets up rpaths and other things to enable it.

If you want to compile another application against it using pkgconfig I would expect you'd configure that application telling pkgconfig to search rdma-core/build/lib/pkgconfig for the .pc files before searching system directories, and then those .pc files should mirror the IN_PLACE setup and include -I and -L directives pointing to the build directory, not to system paths.

Ok, will do.

jgunthorpe · 2018-09-01T21:12:35Z

CMakeLists.txt

+    set(NL_CFLAGS ${NL3_CFLAGS})
+    set(NL_LDFLAGS ${NL3_LDFLAGS})
+    # CMake separates ldflags with a semicolon, cannot be used in a command
+    string(REPLACE ";" " " NL_LDFLAGS "${NL_LDFLAGS}")


Why is this needed here but not below for NL1 ? Isn't this just list to string conversion?

Because nl1 only adds one flag, so cmake doesn't add a semicolon.

That is relying a bit too much on cmake internal behavior, if the flags are cmake lists then they should always be converted.. Probably the helper function should be doing this conversion to keep with cmake convention of using lists for arguments.

Sure, I'll change it that way

rleon · 2018-09-02T02:53:02Z

Should we revert the PR?

…

On Sun, Sep 2, 2018, 04:56 Jason Gunthorpe ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In CMakeLists.txt <#373 (comment)>: > @@ -368,6 +368,10 @@ if (ENABLE_RESOLVE_NEIGH) set(NL_KIND 3) set(NL_INCLUDE_DIRS ${NL3_INCLUDE_DIRS}) set(NL_LIBRARIES ${NL3_LIBRARIES}) + set(NL_CFLAGS ${NL3_CFLAGS}) + set(NL_LDFLAGS ${NL3_LDFLAGS}) + # CMake separates ldflags with a semicolon, cannot be used in a command + string(REPLACE ";" " " NL_LDFLAGS "${NL_LDFLAGS}") That is relying a bit too much on cmake internal behavior, if the flags are cmake lists then they should always be converted.. Probably the helper function should be doing this conversion to keep with cmake convention of using lists for arguments. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#373 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAbhEE5ZJKJKaKfoBO0nbmwBcqBoNJEUks5uWzrDgaJpZM4WQWq4> .

bluca · 2018-09-02T10:23:28Z

Should we revert the PR?

I'll send the requested changes later tonight

bluca · 2018-09-02T13:50:00Z

#374

Pkgconfig: followup changes from PR #373

bluca force-pushed the pkgconfig branch 2 times, most recently from 7726a2d to dc0b275 Compare August 28, 2018 21:15

rleon requested changes Aug 30, 2018

View reviewed changes

bluca force-pushed the pkgconfig branch from dc0b275 to 1d106e3 Compare August 30, 2018 08:53

bluca added 2 commits August 30, 2018 18:39

Generate and install pkgconfig files for libs

df5fe3c

Add a template and generate a pc file for each shared library using CMake. Signed-off-by: Luca Boccassi <bluca@debian.org>

libibverbs-dev: add dependency on NL packages for static builds

55f34cd

ibverbs uses NL3, which has to be present when doing statically linked builds, so add the dependencies on the libibverbs-dev library. Signed-off-by: Luca Boccassi <bluca@debian.org>

bluca force-pushed the pkgconfig branch from 1d106e3 to 55f34cd Compare August 30, 2018 17:39

bluca changed the title ~~Genearate and install pkgconfig files for the RDMA libraries~~ Generate and install pkgconfig files for the RDMA libraries Aug 30, 2018

rleon merged commit 65e0b30 into linux-rdma:master Aug 31, 2018

bluca deleted the pkgconfig branch August 31, 2018 16:23

jgunthorpe reviewed Sep 1, 2018

View reviewed changes

bluca mentioned this pull request Sep 2, 2018

Pkgconfig: followup changes from PR #373 #374

Merged

jgunthorpe added a commit that referenced this pull request Sep 8, 2018

Merge pull request #374 from bluca/pkgconfig

a2e3979

Pkgconfig: followup changes from PR #373

janekmi mentioned this pull request Aug 24, 2020

Package 'libibverbs', required by 'virtual:world', not found pmem/rpma#289

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate and install pkgconfig files for the RDMA libraries #373

Generate and install pkgconfig files for the RDMA libraries #373

bluca commented Aug 28, 2018 •

edited

Loading

bdrung commented Aug 29, 2018

rleon left a comment

rleon Aug 30, 2018

bluca Aug 30, 2018

rleon Aug 30, 2018

jgunthorpe Sep 1, 2018

bluca Sep 2, 2018

jgunthorpe Sep 2, 2018

bluca Sep 2, 2018

bluca commented Aug 30, 2018

rleon commented Aug 30, 2018

bluca commented Aug 30, 2018

rleon commented Aug 31, 2018

jgunthorpe Sep 1, 2018

jgunthorpe Sep 1, 2018

bluca Sep 2, 2018

jgunthorpe Sep 2, 2018

bluca Sep 2, 2018

jgunthorpe Sep 1, 2018

bluca Sep 2, 2018

jgunthorpe Sep 2, 2018

bluca Sep 2, 2018

jgunthorpe Sep 1, 2018

bluca Sep 2, 2018

jgunthorpe Sep 2, 2018

bluca Sep 2, 2018

rleon commented Sep 2, 2018 via email

bluca commented Sep 2, 2018

bluca commented Sep 2, 2018

Generate and install pkgconfig files for the RDMA libraries #373

Generate and install pkgconfig files for the RDMA libraries #373

Conversation

bluca commented Aug 28, 2018 • edited Loading

bdrung commented Aug 29, 2018

rleon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bluca commented Aug 30, 2018

rleon commented Aug 30, 2018

bluca commented Aug 30, 2018

rleon commented Aug 31, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rleon commented Sep 2, 2018 via email

bluca commented Sep 2, 2018

bluca commented Sep 2, 2018

bluca commented Aug 28, 2018 •

edited

Loading