mlx5: Fix potential arithmetic overflow #778
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix potential arithmetic overflow by converting byte_count's type to uint64_t. Prior to this conversion the temporary calculation of byte_count * repeat_count was done in 32-bit arithmetic and could overflow, thus resulting in an incorrect value stored in reglen, which is uint64_t. The following coverity check revealed it: Error: OVERFLOW_BEFORE_WIDEN (CWE-190): rdma-core-28.0/providers/mlx5/qp.c:2137: overflow_before_widen: Potentially overflowing expression "byte_count * repeat_count" with type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "uint64_t" (64 bits, unsigned). rdma-core-28.0/providers/mlx5/qp.c:2137: remediation: To avoid overflow, cast either "byte_count" or "repeat_count" to type "uint64_t". # 2135| # 2136| rb->byte_count = htobe32(byte_count); # 2137|-> *reglen = byte_count * repeat_count; # 2138| # 2139| tmp = align(num_interleaved + 1, 4) - num_interleaved - 1; Fixes: 75ed7a9 ("mlx5: Introduce mlx5dv_wr_mr_interleaved post send builder") Signed-off-by: Avihai Horon <avihaih@mellanox.com> Signed-off-by: Yishai Hadas <yishaih@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix potential arithmetic overflow that was reported by Coverity.