Misc pyverbs tests fixes round 2 #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardSro
suggested changes
Jun 23, 2020
| except PyverbsRDMAError: | ||
| except PyverbsRDMAError as ex: | ||
| if ex.error_code == errno.EOPNOTSUPP: | ||
| raise unittest.SkipTest('Create memory window of type {} is not supported'.format(mw_type)) |
There was a problem hiding this comment.
please use f-strings in the future
tests/test_mr.py
Outdated
| except PyverbsRDMAError: | ||
| except PyverbsRDMAError as ex: | ||
| if ex.error_code == errno.EOPNOTSUPP: | ||
| raise unittest.SkipTest('Create memory window of type {} is not supported'.format(mw_type)) | ||
| pass |
There was a problem hiding this comment.
please remove the "pass" - it's redundant right now
| @@ -71,15 +71,16 @@ def test_query_gid(self): | |||
| ctx.query_gid(port_num=1, index=0) | |||
|
|
|||
| @staticmethod | |||
| def verify_device_attr(attr): | |||
| def verify_device_attr(attr, device): | |||
| """ | |||
| Helper method that verifies correctness of some members of DeviceAttr | |||
| object. | |||
| :param attr: A DeviceAttr object | |||
There was a problem hiding this comment.
please add the device param to the docstring
tests/test_device.py
Outdated
| """ | ||
| Helper method that verifies correctness of some members of DeviceAttr | ||
| object. | ||
| :param attr: A DeviceAttr object | ||
| :return: None | ||
| """ | ||
| assert attr.node_guid != 0 | ||
| assert attr.sys_image_guid != 0 | ||
| if device.node_type != 'Unknown': |
There was a problem hiding this comment.
do you mean "IBV_NODE_UNKNOWN" ?
node_type is not a string (it's just printed as a string using an internal translation function)
added 5 commits
June 30, 2020 12:27
Skip unsupported MW type when EOPNOTSUPP is raised. Signed-off-by: Chen Brasch <cbrasch@amazon.com> Signed-off-by: Gal Pressman <galpress@amazon.com>
ibv_req_notify_cq returns the error code on failure, it doesn't set the errno. Signed-off-by: Chen Brasch <cbrasch@amazon.com> Signed-off-by: Gal Pressman <galpress@amazon.com>
Verify net interface support on RDMATestCase. Skip in case net directory is not found, instead of raising an error. Signed-off-by: Chen Brasch <cbrasch@amazon.com> Signed-off-by: Gal Pressman <galpress@amazon.com>
IBV_QP_STATE should be used on query QP instead of IBV_QP_CUR_STATE, which should only be used for modify QP commands. Signed-off-by: Chen Brasch <cbrasch@amazon.com> Signed-off-by: Gal Pressman <galpress@amazon.com>
Skip verification of a few device attributes in case the node type is unspecified/unknown. The missing IBV_NODE_UNSPECIFIED enum value was added to libibverbs_enums.pxd. Signed-off-by: Chen Brasch <cbrasch@amazon.com> Signed-off-by: Gal Pressman <galpress@amazon.com>
gal-pressman
force-pushed
the
pyverbs-fixes-round2-pr
branch
from
63c338d
to
20e13b0
Compare
EdwardSro
approved these changes
Jun 30, 2020
EdwardSro
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another set of pyverbs fixes which allow tests of unsupported devices to skip.