pyverbs: ODP refactoring and extensions #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardSro
force-pushed
the
pr-odp-additions
branch
from
2079b8b
to
f8a2295
Compare
The implicit ODP MR covers the entire memory space of a process. Applications using implicit ODP can use the entire address range when writing to the MR, instead of being limited to the address space registered to the MR. This also saves actual pages registration so that application control path is faster. Signed-off-by: Itay Aveksis <itayav@mellanox.com> Signed-off-by: Edward Srouji <edwards@mellanox.com>
Add a new test for implicit ODP MRs using RC QP. Signed-off-by: Itay Aveksis <itayav@mellanox.com> Signed-off-by: Edward Srouji <edwards@mellanox.com>
For the implicit MR registrations the internal MR's buffer doesn't have to be allocated (controlled by the length argument). Therefore we should protect the write and read methods of MR object by checking before the operation if the buf attribute and the passed arguments are valid. Signed-off-by: Itay Aveksis <itayav@mellanox.com> Signed-off-by: Edward Srouji <edwards@mellanox.com>
Add a new parameter required_odp_caps to odp's decorator in order to allow users to pass the required mask for the test. Change the test cases to provide the resources class instead of the QP type. Signed-off-by: Ido Kalir <idok@mellanox.com> Signed-off-by: Edward Srouji <edwards@mellanox.com>
The current implementation of write() doesn't take an offset parameter. In UD this means that extra 40 bytes need to be written, so that the GRH won't override the beginning of the message. Add offset parameter to write(). Signed-off-by: Maxim Chicherin <maximc@mellanox.com> Signed-off-by: Edward Srouji <edwards@mellanox.com>
Split OdpUD MRs per operation (send mr and recv mr) to enable using ODP only in the send MR. Signed-off-by: Ido Kalir <idok@mellanox.com> Signed-off-by: Edward Srouji <edwards@mellanox.com>
EdwardSro
force-pushed
the
pr-odp-additions
branch
from
f8a2295
to
ccce439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series introduces new tests for ODP, in addition to infrastructure extensions and a refactoring of the ODP tests, which allows more flexibility for adding new tests in the future.
This includes: