tests: Skip tests with unsupported MR access flags #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardSro
reviewed
Jul 13, 2020
tests/test_qpex.py
Outdated
| self.mr = u.create_custom_mr(self, e.IBV_ACCESS_REMOTE_WRITE) | ||
| try: | ||
| access_flags = e.IBV_ACCESS_REMOTE_WRITE | ||
| self.mr = u.create_custom_mr(self, access_flags) |
There was a problem hiding this comment.
hm.. why not to include this try-catch check inside the create_custom_mr itself?
This will cover all current/future similar scenarios that call create_custom_mr.
The shared PD test triggers a flow that tries to create an MR through QpExRCRDMAWrite class with access flags that might not be supported on some devices, skip the test in that case. Signed-off-by: Gal Pressman <galpress@amazon.com>
gal-pressman
force-pushed
the
shared-pd-test-fix-pr
branch
from
6f1380d
to
ab66851
Compare
EdwardSro
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shared PD test triggers a flow that tries to create an MR through
QpExRCRDMAWrite class with access flags that might not be supported on
some devices, skip the test in that case.
Signed-off-by: Gal Pressman galpress@amazon.com