ci: Use supported ansible-lint action; run ansible-lint against the collection #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=========================================
+ Coverage 0 32.95% +32.95%
=========================================
Files 0 3 +3
Lines 0 613 +613
Branches 0 128 +128
=========================================
+ Hits 0 202 +202
- Misses 0 411 +411
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
richm
force-pushed
the
ansible-lint-test-2.16
branch
from
6428702
to
ae584b5
Compare
|
[citest] |
richm
force-pushed
the
ansible-lint-test-2.16
branch
from
ae584b5
to
1efee22
Compare
|
[citest] |
|
centos 7 and 9 failures are baseos ci issues - the tests pass on those platforms locally |
rjeffman
approved these changes
Dec 22, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The new ansible-lint has several checks related to ansible-test and the ignore files. Many of our ignore settings are not allowed any more and are required to be fixed or addressed in the Ansible preferred way. The python imports have to be wrapped in a try/except ImportError, and where possible, an error must be returned from the module explaining what was not able to be imported. The result of this is that the .sanity files can be reduced to the bare minimum which will greatly reduce the maintenance burden of those files, make it easier to support newer versions of Ansible, and make it easier to import the system roles collection into Galaxy and Automation Hub. `distutils.version` is deprecated, and it is a hard error in python 3.12 Instead, use `packaging.version` - unfortunately, this means having to add a dependency on `python3-packaging` on platforms that support it - notably, there is no python-packaging available on EL7, so fall back to using `distutils.version` there. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
force-pushed
the
ansible-lint-test-2.16
branch
from
1efee22
to
ee5e5b7
Compare
spetrosi
reviewed
Jan 4, 2024
| run_after: | ||
| description: | ||
| - Command that should run after saving the certificate. | ||
| required: false |
There was a problem hiding this comment.
Why are you removing required: false?
There was a problem hiding this comment.
The default is required: false - better style to omit required unless required: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old ansible-community ansible-lint is deprecated. There is a
new ansible-lint github action. The new ansible-lint has several checks
related to ansible-test and the ignore files. Many of our ignore settings
are not allowed any more and are required to be fixed or addressed in the
Ansible preferred way.
The python imports have to be wrapped in a try/except ImportError, and
where possible, an error must be returned from the module explaining
what was not able to be imported.
The result of this is that the .sanity files can be reduced to the
bare minimum which will greatly reduce the maintenance burden of
those files, make it easier to support newer versions of Ansible,
and make it easier to import the system roles collection into Galaxy
and Automation Hub.
distutils.versionis deprecated, and it is a hard error in python 3.12Instead, use
packaging.version- unfortunately, this means having toadd a dependency on
python3-packagingon platforms that support it -notably, there is no python-packaging available on EL7, so fall back
to using
distutils.versionthere.The latest Ansible repo gating tests run ansible-lint against
the collection format instead of against individual roles.
We have to convert the role to collection format before running
ansible-test.
Role developers can run this locally using
tox -e collection,ansible-lint-collectionSee linux-system-roles/tox-lsr#125
Add
---doc start to .markdownlint.yamlSigned-off-by: Rich Megginson rmeggins@redhat.com