ansible lint collection #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richm
commented
May 11, 2023
richm
commented
- Use check-ansible-managed.sh script instead of inline bash
- Use allowlist instead of whitelist
- add ansible-lint-collection
richm
force-pushed
the
ansible-lint-collection
branch
2 times, most recently
from
dd0fd5e
to
df841c9
Compare
spetrosi
approved these changes
May 16, 2023
Add testenv for `ansible-lint-collection` that runs `ansible-lint` against a collection created with the `collection` testenv. Updated yamllint.yml with the latest fixes. Updated runcollection.sh to include some fixes to allow ansible-lint to pass.
richm
force-pushed
the
ansible-lint-collection
branch
from
df841c9
to
3cd88ca
Compare
richm
added a commit
to linux-system-roles/kernel_settings
that referenced
this pull request
May 17, 2023
The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 ha_cluster - add to python_roles metrics - fix ansible-lint Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/kernel_settings
that referenced
this pull request
Dec 13, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/kernel_settings
that referenced
this pull request
Dec 13, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/kernel_settings
that referenced
this pull request
Dec 13, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/kernel_settings
that referenced
this pull request
Dec 13, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/kernel_settings
that referenced
this pull request
Dec 13, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/kernel_settings
that referenced
this pull request
Dec 13, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/kernel_settings
that referenced
this pull request
Dec 13, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/kernel_settings
that referenced
this pull request
Dec 13, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/kernel_settings
that referenced
this pull request
Dec 13, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/linux-system-roles-network
that referenced
this pull request
Dec 14, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The new ansible-lint has several checks related to ansible-test and the ignore files. Many of our ignore settings are not allowed any more and are required to be fixed or addressed in the Ansible preferred way. The python imports have to be wrapped in a try/except ImportError, and where possible, an error must be returned from the module explaining what was not able to be imported. The module documentation must comply with the Ansible standards. The result of this is that the .sanity files can be reduced to the bare minimum which will greatly reduce the maintenance burden of those files, make it easier to support newer versions of Ansible, and make it easier to import the system roles collection into Galaxy and Automation Hub. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml The file tests/integration/conftest.py is no longer used. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/linux-system-roles-network
that referenced
this pull request
Dec 14, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The new ansible-lint has several checks related to ansible-test and the ignore files. Many of our ignore settings are not allowed any more and are required to be fixed or addressed in the Ansible preferred way. The python imports have to be wrapped in a try/except ImportError, and where possible, an error must be returned from the module explaining what was not able to be imported. The module documentation must comply with the Ansible standards. One aspect of this is the `version_added` must be a valid ansible-core version in X.Y.Z format. Note that this version isn't really used anywhere, so it doesn't matter for users of the role, it is purely an `ansible-test` and import gating issue. The result of this is that the .sanity files can be reduced to the bare minimum which will greatly reduce the maintenance burden of those files, make it easier to support newer versions of Ansible, and make it easier to import the system roles collection into Galaxy and Automation Hub. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml The file tests/integration/conftest.py is no longer used. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/linux-system-roles-network
that referenced
this pull request
Dec 14, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The new ansible-lint has several checks related to ansible-test and the ignore files. Many of our ignore settings are not allowed any more and are required to be fixed or addressed in the Ansible preferred way. The python imports have to be wrapped in a try/except ImportError, and where possible, an error must be returned from the module explaining what was not able to be imported. The module documentation must comply with the Ansible standards. One aspect of this is the `version_added` must be a valid ansible-core version in X.Y.Z format. Note that this version isn't really used anywhere, so it doesn't matter for users of the role, it is purely an `ansible-test` and import gating issue. The result of this is that the .sanity files can be reduced to the bare minimum which will greatly reduce the maintenance burden of those files, make it easier to support newer versions of Ansible, and make it easier to import the system roles collection into Galaxy and Automation Hub. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml The file tests/integration/conftest.py is no longer used. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/linux-system-roles-storage
that referenced
this pull request
Dec 15, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The new ansible-lint has several checks related to ansible-test and the ignore files. Many of our ignore settings are not allowed any more and are required to be fixed or addressed in the Ansible preferred way. The python imports have to be wrapped in a try/except ImportError, and where possible, an error must be returned from the module explaining what was not able to be imported. The module documentation must comply with the Ansible standards. One aspect of this is the `version_added` must be a valid ansible-core version in X.Y.Z format. Note that this version isn't really used anywhere, so it doesn't matter for users of the role, it is purely an `ansible-test` and import gating issue. I created a function `generate_module_doc` which will generate the DOCUMENTATION options section from the Ansible module_args, if necessary. Hopefully it won't be necessary going forward. I fought a losing battle with flake8, pep8, etc. in ansible-test to try to preserve the formatting in size.py - future developers are welcome to try. The result of this is that the .sanity files can be reduced to the bare minimum which will greatly reduce the maintenance burden of those files, make it easier to support newer versions of Ansible, and make it easier to import the system roles collection into Galaxy and Automation Hub. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml Fixed some other linter errors in some tests files. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/linux-system-roles-kernel_settings
that referenced
this pull request
Dec 15, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/linux-system-roles-storage
that referenced
this pull request
Dec 15, 2023
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The new ansible-lint has several checks related to ansible-test and the ignore files. Many of our ignore settings are not allowed any more and are required to be fixed or addressed in the Ansible preferred way. The python imports have to be wrapped in a try/except ImportError, and where possible, an error must be returned from the module explaining what was not able to be imported. The module documentation must comply with the Ansible standards. One aspect of this is the `version_added` must be a valid ansible-core version in X.Y.Z format. Note that this version isn't really used anywhere, so it doesn't matter for users of the role, it is purely an `ansible-test` and import gating issue. I created a function `generate_module_doc` which will generate the DOCUMENTATION options section from the Ansible module_args, if necessary. Hopefully it won't be necessary going forward. I fought a losing battle with flake8, pep8, etc. in ansible-test to try to preserve the formatting in size.py - future developers are welcome to try. The result of this is that the .sanity files can be reduced to the bare minimum which will greatly reduce the maintenance burden of those files, make it easier to support newer versions of Ansible, and make it easier to import the system roles collection into Galaxy and Automation Hub. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Add `---` doc start to .markdownlint.yaml Fixed some other linter errors in some tests files. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/postfix
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/podman
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/pam_pwd
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/nbde_server
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/journald
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/fapolicyd
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/certificate
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/nbde_client
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/keylime_server
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/kernel_settings
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/logging
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/kdump
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/ha_cluster
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/firewall
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/crypto_policies
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/template
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/mssql
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/mssql
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/ansible-sshd
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Fix ansible-lint and ansible-test issues reported by the latest 2.16 versions. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/ansible-sshd
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Fix ansible-lint and ansible-test issues reported by the latest 2.16 versions. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/ansible-sshd
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Fix ansible-lint and ansible-test issues reported by the latest 2.16 versions. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/ssh
that referenced
this pull request
Jan 8, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/lsr_.github
that referenced
this pull request
Jan 8, 2024
The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 ha_cluster - add to python_roles metrics - fix ansible-lint Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/.github
that referenced
this pull request
Jan 10, 2024
The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 ha_cluster - add to python_roles metrics - fix ansible-lint Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to richm/linux-system-roles-network
that referenced
this pull request
Jan 11, 2024
… 2.16 The old ansible-community ansible-lint github action is deprecated. There is a new ansible-lint github action called `ansible/ansible-lint`. However, this version requires a collection, so we have to convert the role to collection format before running the ansible-lint action. tox-lsr has been updated to use ansible-core 2.16 for ansible-lint and ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/network
that referenced
this pull request
Jan 12, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm
added a commit
to linux-system-roles/mssql
that referenced
this pull request
Jan 15, 2024
…ollection The old ansible-community ansible-lint is deprecated. There is a new ansible-lint github action. The latest Ansible repo gating tests run ansible-lint against the collection format instead of against individual roles. We have to convert the role to collection format before running ansible-test. This also requires tox-lsr 3.2.1 - bump other actions to use 3.2.1 Role developers can run this locally using `tox -e collection,ansible-lint-collection` See linux-system-roles/tox-lsr#125 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.