Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add support for SUSE ALP-Dolomite #215

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

HVSharma12
Copy link
Contributor

Enhancement: Add support for SUSE ALP-Dolomite in the certificate Ansible role.

Reason: This enhancement aims to introduce compatibility by adjusting file paths, package dependencies

Result: Updated the certificate role for SUSE ALP-Dolomite

Issue Tracker Tickets (Jira or BZ if any):na

@spetrosi
Copy link
Collaborator

Did you test this against Suse and can you confirm that this change is sufficient?

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b77c7fd) 32.95% compared to head (b87609b) 32.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   32.95%   32.95%           
=======================================
  Files           3        3           
  Lines         613      613           
  Branches      128      128           
=======================================
  Hits          202      202           
  Misses        411      411           
Flag Coverage Δ
sanity 32.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HVSharma12
Copy link
Contributor Author

@spetrosi yes the role works as expected on Suse ALP-Dolomite tested all the mentioned examples also using certificate_test_mode=true&certificate_test_remove_files=true.

@richm
Copy link
Collaborator

richm commented Jan 17, 2024

@HVSharma12 the files in .ostree - I guess ALP Dolomite is similar to ostree? You build a read-only image using packages specified in files in the .ostree directory? For example, for RedHat family, we use osbuild to build ostree images e.g. https://github.com/linux-system-roles/tox-lsr#building-ostree-images - is ALP Dolomite similar?

@richm richm merged commit 2f95296 into linux-system-roles:main Jan 17, 2024
18 checks passed
@HVSharma12
Copy link
Contributor Author

@richm ALP Dolomite and OSTree have different approaches. While OSTree involves building read-only images with predefined packages (like using .ostree directory in RedHat systems), ALP Dolomite centers around atomic, transactional updates, creating a new snapshot to apply the changes such as package installs you need to reboot the host, not necessarily on building images with a set package list as in OSTree. - although I am looking into options for them to be managed similarly for linux-system-roles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants