Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(changelog): version 1.3.4 [citest skip] #222

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

spetrosi
Copy link
Collaborator

@spetrosi spetrosi commented Apr 2, 2024

Update changelog and .README.html for version 1.3.4

Signed-off-by: Sergei Petrosian spetrosi@redhat.com

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.95%. Comparing base (33bac79) to head (a6b6e35).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   32.95%   32.95%           
=======================================
  Files           3        3           
  Lines         613      613           
  Branches      128      128           
=======================================
  Hits          202      202           
  Misses        411      411           
Flag Coverage Δ
sanity 32.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjeffman
Copy link
Collaborator

rjeffman commented Apr 2, 2024

Only now I saw that ansible-lint was bumped to version 24. In ansible-freeipa we found that this version is "hit and miss" and was unstable. Is it required to use version 24 right now?

@richm
Copy link
Collaborator

richm commented Apr 2, 2024

Only now I saw that ansible-lint was bumped to version 24. In ansible-freeipa we found that this version is "hit and miss" and was unstable. Is it required to use version 24 right now?

We generally use whatever version Galaxy and Automation Hub use for gating, and right now that is 24. What issues are you seeing?

@rjeffman
Copy link
Collaborator

rjeffman commented Apr 2, 2024

There were lots of failures on it creating the virtual environment.

We also (try to) use the same version as Galaxy and Automation Hub, and if it is using 24, I'll update it there.

Copy link
Collaborator

@rjeffman rjeffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@richm
Copy link
Collaborator

richm commented Apr 2, 2024

There were lots of failures on it creating the virtual environment.

ansible-lint, or ansible-test?

We also (try to) use the same version as Galaxy and Automation Hub, and if it is using 24, I'll update it there.

@rjeffman
Copy link
Collaborator

rjeffman commented Apr 3, 2024

ok... I found out the issue with ansible-lint, and it was on ansible-freeipa. It is fixed now.

Update changelog and .README.html for version 1.3.4

Signed-off-by: Sergei Petrosian <spetrosi@redhat.com>
@richm richm merged commit ac27251 into linux-system-roles:main Apr 4, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants