-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(changelog): version 1.3.4 [citest skip] #222
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
=======================================
Coverage 32.95% 32.95%
=======================================
Files 3 3
Lines 613 613
Branches 128 128
=======================================
Hits 202 202
Misses 411 411
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Only now I saw that ansible-lint was bumped to version 24. In ansible-freeipa we found that this version is "hit and miss" and was unstable. Is it required to use version 24 right now? |
We generally use whatever version Galaxy and Automation Hub use for gating, and right now that is 24. What issues are you seeing? |
There were lots of failures on it creating the virtual environment. We also (try to) use the same version as Galaxy and Automation Hub, and if it is using 24, I'll update it there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
ansible-lint, or ansible-test?
|
ok... I found out the issue with ansible-lint, and it was on ansible-freeipa. It is fixed now. |
Update changelog and .README.html for version 1.3.4 Signed-off-by: Sergei Petrosian <spetrosi@redhat.com>
Update changelog and .README.html for version 1.3.4
Signed-off-by: Sergei Petrosian spetrosi@redhat.com