fix: no longer use "item" as a loop variable

[berndfinger]

By using a different loop variable, we can avoid WARNING messages related to loop variables when calling the selinux role from another role.

Fixes: #216 .

Enhancement: Avoid the warning message:

[WARNING]: TASK: fedora.linux_system_roles.selinux : Restore SELinux labels on filesystem tree: The loop variable 'item' is already in use.
You should set the `loop_var` value in the `loop_control` option for the task to something else to avoid variable collisions and unexpected behavior.

Reason: Although I am not aware of any errors when using the role selinux without this fix, the warning message (printed in bold and in a different than usual color - violet in my tests) adds lines to the output which can confuse users.

Result: The warning message `[WARNING]: TASK: ... "The loop variable 'item' is already in use." is no longer displayed when calling the role from another role.

Issue Tracker Tickets (Jira or BZ if any): N/A

[richm]

Thanks - in fact I would suggest you go further and use __selinux_item as the loop variable to go along with the general practice of naming role private variables with the __$ROLENAME_ prefix.

[berndfinger]

I like the idea of naming the loop variable to also contain the role name. See 5bff24d.

[richm]

[citest]

[richm]

These test failures are really strange - I don't think they are related to the PR - investigating

[richm]

@berndfinger in tasks/selinux_load_module.yml item needs to be renamed to __selinux_item

[richm]

[citest]