fix: Print an error message when module to be created doesn't exist #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richm
reviewed
Dec 8, 2023
tasks/selinux_load_module.yml
Outdated
| when: not module_file.stat.checksum in checksum | ||
| when: >- | ||
| (not module_file.stat.exists) or | ||
| (module_file.stat.exists and not module_file.stat.checksum in checksum) |
There was a problem hiding this comment.
while this seems correct, unfortunately it will break https://github.com/linux-system-roles/selinux/blob/main/tests/tests_selinux_modules.yml#L149 because an error won't be raised by this code. I think we should not fix this. Or, if we do, we need to figure out if it is ok to always raise an error if not module_file.stat.exists
spetrosi
force-pushed
the
load_module_check_exists
branch
from
326d2e7
to
41e489f
Compare
spetrosi
changed the title
|
[citest] |
richm
reviewed
Dec 8, 2023
tasks/selinux_load_module.yml
Outdated
| @@ -26,6 +26,11 @@ | |||
| delegate_to: localhost | |||
| become: false | |||
|
|
|||
| - name: Raise an error when module file doesn't exist | |||
| fail: | |||
| msg: The module that you try to install doesn't exist in {{ item.path }} | |||
There was a problem hiding this comment.
Suggested change
| msg: The module that you try to install doesn't exist in {{ item.path }} | |
| msg: The module that you try to install doesn't exist in {{ __selinux_item.path }} |
spetrosi
force-pushed
the
load_module_check_exists
branch
from
41e489f
to
14e980a
Compare
spetrosi
force-pushed
the
load_module_check_exists
branch
from
14e980a
to
81480a3
Compare
|
[citest] |
|
the rhel6 and 7 failures are known and seen occasionally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Print an error message when module to be created doesn't exist
Reason: When specifying a non-existent file with
selinux_modules.paththe role fails with an informative message that the module file that you try to install doesn't exist.