Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider clarifying documentation #385

Closed
myllynen opened this issue Sep 26, 2023 · 0 comments · Fixed by #456
Closed

Consider clarifying documentation #385

myllynen opened this issue Sep 26, 2023 · 0 comments · Fixed by #456
Assignees

Comments

@myllynen
Copy link

Currently the README states:

As of now, the role supports managing file systems and mount entries on

    unpartitioned disks
    lvm (unpartitioned whole-disk physical volumes only)

However, it looks like the role is also able to create new LVs on existing VGs (created earlier perhaps during OS installation).

Additionally, it is not mentioned that disks is optional for storage_pools and examples do not demonstrate such usage.

Perhaps documentation could be clarified a bit in this regard if it is a valid and supported use case for the role to be used in cases without specifying disks.

Thanks.

@vojtechtrefny vojtechtrefny self-assigned this Sep 26, 2023
vojtechtrefny added a commit to vojtechtrefny/storage that referenced this issue Jul 17, 2024
Missing information about Stratis support, default value for
`grow_to_fill`, notes about pool type-specific arguments etc.

Resolves: linux-system-roles#455
Resolves: linux-system-roles#428
Resolves: linux-system-roles#385
Related: linux-system-roles#437
vojtechtrefny added a commit to vojtechtrefny/storage that referenced this issue Jul 17, 2024
Missing information about Stratis support, default value for
`grow_to_fill`, notes about pool type-specific arguments etc.

Resolves: linux-system-roles#455
Resolves: linux-system-roles#428
Resolves: linux-system-roles#385
Related: linux-system-roles#437
vojtechtrefny added a commit to vojtechtrefny/storage that referenced this issue Jul 17, 2024
Missing information about Stratis support, default value for
`grow_to_fill`, notes about pool type-specific arguments,
partitioning support, formatting etc.

Resolves: linux-system-roles#455
Resolves: linux-system-roles#428
Resolves: linux-system-roles#385
Related: linux-system-roles#437
@richm richm closed this as completed in 06844b5 Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants