Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ltp/testcases/kernel/fs/dmapi/hole.c: 2* wierd coding ? #156

Closed
dcb314 opened this issue May 11, 2017 · 1 comment
Closed

ltp/testcases/kernel/fs/dmapi/hole.c: 2* wierd coding ? #156

dcb314 opened this issue May 11, 2017 · 1 comment

Comments

@dcb314
Copy link

dcb314 commented May 11, 2017

ltp/testcases/kernel/fs/dmapi/hole.c:1216]: (error) Expression '(off=lseek(fd,500000-(sizeof("0123456789")-1),SEEK_SET))!=off' depends on order of evaluation of side effects

Source code is

       ((off =
          lseek(fd, TMP_FILELEN - DUMMY_STRLEN, SEEK_SET)) != off)

ltp/testcases/kernel/fs/dmapi/hole.c:1209]: (error) Expression '(off=lseek(fd,i,SEEK_SET))!=off' depends on order of evaluation of side effects

Duplicate.

@metan-ucw
Copy link
Member

This code is even skipped from a compilation. Maybe it's time to remove the whole dmapi directory.

metan-ucw added a commit that referenced this issue May 24, 2017
The test was skipped from compilation for quite a long time, there is no
point in keeping it in the tree.

See also:
#156

Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants