Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oom03, oom05, ksm03, ksm04 testcases don't work with cgroup2 #611

Closed
jstancek opened this issue Oct 30, 2019 · 4 comments
Closed

oom03, oom05, ksm03, ksm04 testcases don't work with cgroup2 #611

jstancek opened this issue Oct 30, 2019 · 4 comments
Labels
bug

Comments

@jstancek
Copy link
Contributor

http://lists.linux.it/pipermail/ltp/2019-October/014141.html

systemd on Fedora31 started using cgroup2 exclusively:
cgroup2 on /sys/fs/cgroup type cgroup2 (rw,nosuid,nodev,noexec,relatime,seclabel,nsdelegate)

oom03, oom05 tests are trying to mount single controller on cgroup1 and get EBUSY

[pid 283933] 04:57:26 mkdir("/dev/cgroup", 0777) = 0
[pid 283933] 04:57:26 mount("memcg", "/dev/cgroup", "cgroup", 0, "memory") = -1 EBUSY (Device or resource busy)
@jstancek jstancek added the bug label Oct 30, 2019
@jstancek jstancek changed the title oom03, oom05 testcases don't work with cgroup2 oom03, oom05, ksm03, ksm04 testcases don't work with cgroup2 Nov 19, 2019
@jstancek
Copy link
Contributor Author

ksm03/ksm04 appear to run into same problem on Fedora31

tag=ksm03 stime=1574117009
cmdline="ksm03"
contacts=""
analysis=exit
<<<test_output>>>
tst_test.c:1215: INFO: Timeout per run is 0h 05m 00s
mem.c:757: BROK: mount /dev/cgroup: EBUSY (16)

@idorax idorax mentioned this issue Apr 7, 2020
Merged
rasibley pushed a commit to CKI-project/tests-beaker that referenced this issue Apr 9, 2020
@idorax
FASTMOVING-1161 ltp ksm failure (#500)
9518896 
Enable partial ksm cases to extend test coverage, and keep disabling
    ksm03, ksm03_1, ksm04 and ksm04_01 because they still fail due to
    issue linux-test-project/ltp#611

Signed-off-by: Vector Li <huanli@redhat.com>
linuxqiao pushed a commit to linuxqiao/tests-beaker that referenced this issue Apr 13, 2020
@idorax @linuxqiao
FASTMOVING-1161 ltp ksm failure (CKI-project#500)
f217db3 
Enable partial ksm cases to extend test coverage, and keep disabling
    ksm03, ksm03_1, ksm04 and ksm04_01 because they still fail due to
    issue linux-test-project/ltp#611

Signed-off-by: Vector Li <huanli@redhat.com>
rasibley added a commit to rasibley/tests-beaker that referenced this issue May 13, 2020
@rasibley
Disable kms02 for upstream kernels
b9ff0f2 
This test which is run right after podman tests is using cgroup1
which differs from podman test which uses cgroup2, mixing the two
can cause bad side effects, see the following issue request for more
details.

linux-test-project/ltp#611
@rasibley rasibley mentioned this issue May 13, 2020
Merged
rasibley added a commit to CKI-project/tests-beaker that referenced this issue May 13, 2020
@rasibley
Disable kms02 for upstream kernels (#530)
f887044 
This test which is run right after podman tests is using cgroup1
which differs from podman test which uses cgroup2, mixing the two
can cause bad side effects, see the following issue request for more
details.

linux-test-project/ltp#611
@jstancek
Copy link
Contributor Author

Reference to discussion about ksm02 tests:
https://lore.kernel.org/linux-arm-kernel/1039472143.12305448.1589384415559.JavaMail.zimbra@redhat.com/T/#m7a1095171fdc23a964d2fd4fdb2d55a9751ec401

F32 distro and podman tests use cgroup2 by default, LTP test cgroup1. Mixing those two means that cpuset controller is moving between hierarchies, which is not fully supported/recommended.

@wangli5665
Copy link
Member

A proposal patchset to solve the problem:
http://lists.linux.it/pipermail/ltp/2020-May/017307.html

wangli5665 added a commit to wangli5665/ltp that referenced this issue May 22, 2020
@wangli5665
mem: take use of new cgroup API
58a2c90 
For issue linux-test-project#611:
  linux-test-project#611

Signed-off-by: Li Wang <liwang@redhat.com>
wangli5665 added a commit to wangli5665/ltp that referenced this issue May 22, 2020
@wangli5665
mem: take use of new cgroup API
1917b88 
For issue linux-test-project#611:
  linux-test-project#611

Signed-off-by: Li Wang <liwang@redhat.com>
wangli5665 added a commit to wangli5665/ltp that referenced this issue Jun 9, 2020
@wangli5665
mem: take use of new cgroup API
bd558d2 
For issue linux-test-project#611:
  linux-test-project#611

Signed-off-by: Li Wang <liwang@redhat.com>
wangli5665 added a commit that referenced this issue Jun 19, 2020
@wangli5665
mem: take use of new cgroup API
cff4038 
For issue #611:
  #611

Signed-off-by: Li Wang <liwang@redhat.com>
Reviewed-by: Jan Stancek <jstancek@redhat.com>
@wangli5665
Copy link
Member

With the new cgroup test API merging, I assume this issue has been solved.
Any question please leave a comment or reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jstancek @wangli5665