configure: add knob to control numa support #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to disable numa from the top level. Based on patch: http://cgit.openembedded.org/openembedded-core/commit/meta/recipes-extended/ltp?id=4c7873552e13dfdba96afca7562c398d2966ca71 Reported-by: Roy Li <rongqing.li@windriver.com> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
|
@roxell thank you for your patch although. The patch comes from 2014, when it was needed for cross-compilation as NUMA detection was broken for it. This issue was fixed in commit bf34412, so this is not required as a fix for failing builds. But I liked the idea of allowing user to choose whether compile it with NUMA, so I merged your patch (39a85a1). Unfortunately I overlooked 2 issues, see my post in LTP mailing list, so I'll either fix it or revert (if community does not like the feature): http://lists.linux.it/pipermail/ltp/2018-February/007065.html BTW, if you want to bring more attention to your patches, send them to LTP mailing list: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to disable numa from the top level.
Based on patch:
http://cgit.openembedded.org/openembedded-core/commit/meta/recipes-extended/ltp?id=4c7873552e13dfdba96afca7562c398d2966ca71
Reported-by: Roy Li rongqing.li@windriver.com
Signed-off-by: Anders Roxell anders.roxell@linaro.org