Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static linking with musl-fts #616

Closed
wants to merge 1 commit into from
Closed

Fix static linking with musl-fts #616

wants to merge 1 commit into from

Conversation

ffontaine
Copy link
Contributor

Don't append libraries to LDLIBS but prepend them in cpuset_lib/Makefile
and cpuset/Makefile.inc to allow the user to provide its FTS library
such as -lfts for musl/uclibc through LDLIBS

This will fix static build of ltp with musl-fts on uclibc

Fixes:

Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

Don't append libraries to LDLIBS but prepend them in cpuset_lib/Makefile
and cpuset/Makefile.inc to allow the user to provide its FTS library
such as -lfts for musl/uclibc through LDLIBS

This will fix static build of ltp with musl-fts on uclibc

Fixes:
 - http://autobuild.buildroot.org/results/9155326e1ff7c2bb2218122c453872c2fc76f65e

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
@pevik
Copy link
Member

pevik commented Nov 17, 2019

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Tested-by: Petr Vorel <petr.vorel@gmail.com>

@ffontaine Hi Fabrice, thanks for your patch! Would you mind to send this to LTP mailing list?
https://lists.linux.it/listinfo/ltp
We slightly prefer it as you get bigger audience (https://github.com/linux-test-project/ltp#developers-corner).

@pevik
Copy link
Member

pevik commented Nov 17, 2019

Note, this fix also musl with FTS library (https://github.com/void-linux/musl-fts) or whatever libc is used with FTS.

@ffontaine
Copy link
Contributor Author

Fixed by 22f510d

@ffontaine ffontaine closed this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants