Skip to content

Commit

Permalink
libegt: Add missing dependency on libudev
Browse files Browse the repository at this point in the history
Also fix underlinking errors when using gold linker
Depend on xxd-native, example need xxd during build

Signed-off-by: Khem Raj <raj.khem@gmail.com>
  • Loading branch information
kraj authored and codrin989 committed Dec 18, 2019
1 parent 689c2f2 commit 9af1ce6
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
From 8ffc0ab37d9bf7cc46fa9fa27cc1eb7f88f554b1 Mon Sep 17 00:00:00 2001
From: Khem Raj <raj.khem@gmail.com>
Date: Wed, 4 Dec 2019 23:38:30 -0800
Subject: [PATCH] link libudev for udev_unref and udev_new

These APIs are used in inputlibinput.cpp which is only
compile when HAVE_LIBINPUT is enabled

This shows up when linking with gold linker

../../src/.libs/libegt.so: error: undefined reference to 'udev_new'
../../src/.libs/libegt.so: error: undefined reference to 'udev_unref'
collect2: error: ld returned 1 exit status
Makefile:558: recipe for target 'camera' failed
make[4]: *** [camera] Error 1

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index c38a1d0f..e398dedd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -251,7 +251,7 @@ AS_IF([test "x$with_libinput" != "xno"],[
if test "x${have_libinput}" = xyes; then
AC_DEFINE(HAVE_LIBINPUT, 1, [Have libinput support])
LIBEGT_EXTRA_CXXFLAGS="${LIBINPUT_CFLAGS} ${LIBEGT_EXTRA_CXXFLAGS}"
- LIBEGT_EXTRA_LDFLAGS="${LIBINPUT_LIBS} ${LIBEGT_EXTRA_LDFLAGS}"
+ LIBEGT_EXTRA_LDFLAGS="${LIBINPUT_LIBS} -ludev ${LIBEGT_EXTRA_LDFLAGS}"
fi
])
AM_CONDITIONAL([HAVE_LIBINPUT], [test "x${have_libinput}" = xyes])
--
2.24.0

6 changes: 5 additions & 1 deletion recipes-graphics/libegt/libegt_0.8.bb
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,15 @@ DEPENDS = "\
gstreamer1.0-plugins-base \
libxkbcommon \
libinput \
udev \
xxd-native \
"

DEPENDS_append_at91sam9 = " tslib"

SRC_URI = "gitsm://github.com/linux4sam/egt.git;protocol=https"
SRC_URI = "gitsm://github.com/linux4sam/egt.git;protocol=https \
file://0001-link-libudev-for-udev_unref-and-udev_new.patch \
"

SRCREV = "be50eef497a0900cf90b60a2da4aad30ba0e3663"

Expand Down

0 comments on commit 9af1ce6

Please sign in to comment.