Fix coreboot buildgcc detection #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this improve the detection of coreboot gcc? There is only a dependency target for i386-elf-gcc; we should have a separate one for arm if we need it (which chromebook EC does). |
|
For example x86_64 is also a target :) So in my opinion we should allow every target. |
|
The makefile seems to be detecting coreboot's gcc fine at this point. Reopen this if it is still an issue. |
tlaurion
pushed a commit
to tlaurion/heads
that referenced
this pull request
May 3, 2024
issue linuxboot#59 and issue linuxboot#71
tlaurion
pushed a commit
to tlaurion/heads
that referenced
this pull request
May 3, 2024
Run all pruning through autoprune calendar issue linuxboot#59 and issue linuxboot#65 and issue linuxboot#71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.