Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add flag userPublic #385

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

FeiWang1119
Copy link
Contributor

@FeiWang1119 FeiWang1119 commented Oct 18, 2023

add flag userPublic to Meta file for managing permission among users.

Issue: linuxdeepin/developer-center#5928

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Oct 18, 2023
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#385
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Oct 18, 2023

Doc Check bot
🟢 Document Coverage Check Passed!

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Oct 19, 2023
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#385
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Oct 19, 2023
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#385
@18202781743
Copy link
Contributor

+1

Copy link
Contributor

@kegechen kegechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

zccrs
zccrs previously requested changes Oct 20, 2023
@@ -336,6 +336,8 @@ class Q_DECL_HIDDEN DConfigInfo {
flags |= DConfigFile::NoOverride;
} else if (flag == QLatin1String("global")) {
flags |= DConfigFile::Global;
} else if (flag == QLatin1String("userPublic")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个配置文件的格式没有采用小驼峰命名,用中划线分割代替,这里改为 user-public

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Oct 20, 2023
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#385
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Oct 23, 2023
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#385
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

add flag UserPublic to Meta file for managing permission among users.

Issue: linuxdeepin/developer-center#5928
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Oct 23, 2023
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#385
@kegechen kegechen dismissed zccrs’s stale review October 23, 2023 02:25

requested change is changed

@kegechen kegechen merged commit 9c3e18e into linuxdeepin:master Oct 23, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants