Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: back to widget-like for Menu #346

Merged
merged 1 commit into from
May 31, 2024

Conversation

18202781743
Copy link
Contributor

TODO it exists some bug for InWindowBlur.

Issue: linuxdeepin/developer-center#8631

TODO it exists some bug for InWindowBlur.

Issue: linuxdeepin/developer-center#8631
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • FlowStyle.qml中,padding属性的默认值从10更改为0,需要确认这是否符合设计要求。

  • contentPadding属性在使用ColumnLayout时新增,需要确保它在所有相关场景中都得到了正确的处理。

  • leftPaddingrightPadding的计算方式更改,增加了contentPadding,需要检查是否有必要以及是否会影响布局。

  • MenuItem.qml中,sourceComponentHighlightPanel更改为Rectangle,需要确保新的组件和方法能够满足原有的功能需求。

  • radius属性被设置为0,需要确认是否有必要在这个地方使用硬编码的值,以及是否会影响其他依赖于radius属性的组件或布局。

  • Loader组件中的sourceComponentHighlightPanel更改为Rectangle,需要确保新的组件和方法能够满足原有的功能需求。

合并相似的问题是否建议立即修改:

  • 是,特别是对于硬编码的值和布局的潜在影响,这些需要立即评估以确保代码的质量和功能的正确性。

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request May 27, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#346
@deepin-bot
Copy link
Contributor

deepin-bot bot commented May 27, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 08b19e8 into linuxdeepin:master May 31, 2024
20 of 21 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request May 31, 2024
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants