toxic dde proxy environmental variable sync

[DuckSoft]

🕊️ 🕊️ 🕊️ 🕊️ 🕊️ 🕊️ 🕊️

intro

before stating what the hug was going on, i want to ask everyone an interesting question:

first of all, i have an HTTP proxy on 127.0.0.1:8888, and an HTTPS proxy on example.com:443.
are the following configuration cases correct or not, why and why not?

1. export ftp_proxy=http://127.0.0.1:8888
2. export https_proxy=http://127.0.0.1:8888
3. export http_proxy=https://example.com:443

i want to say that, those are all correct configurations.

🕊️ 🕊️ 🕊️ 🕊️ 🕊️ 🕊️ 🕊️

problem

let's look at the problem itself:
file /proxy/proxy.go is used for deepin desktop environment to sync gsettings proxy entries into environmental variables, which looks pretty good. but if you look deeper, you will get something unusual:

go-lib/proxy/proxy.go

Lines 145 to 159 in 5406dea

	case proxyModeManual:
	doSetEnv(envHttpProxy, getProxyValue(proxyTypeHttp))
	doSetEnv(envHttpsProxy, getProxyValue(proxyTypeHttps))
	doSetEnv(envFtpProxy, getProxyValue(proxyTypeFtp))
	doSetEnv(envSocksProxy, getProxyValue(proxyTypeSocks))
	arrayIgnoreHosts := proxySettings.GetStrv(gkeyProxyIgnoreHosts)
	ignoreHosts := strings.Join(arrayIgnoreHosts, ",")
	doSetEnv(envNoProxy, ignoreHosts)
	// fallback socks proxy value to http to be compatible with Qt>=4.6
	if utils.IsEnvExists(envSocksProxy) && !utils.IsEnvExists(envHttpProxy) {
	doSetEnv(envHttpProxy, os.Getenv(envSocksProxy))
	}
	}

if you look into getProxyValue, you will see that, the program here assumes http_proxy can only use http schemas, and the same for https and ftp.

go-lib/proxy/proxy.go

Line 179 in 5406dea

proxyValue = fmt.Sprintf("%s://%s:%s", proxyType, host, port)

if we admit this, we are to say, none of the configuration cases in our intro section is correct, since ftp_proxy used http, https_proxy used http and http_proxy used https.

🕊️ 🕊️ 🕊️ 🕊️ 🕊️ 🕊️ 🕊️

discovery

i encountered this problem when a random deepin user reported to Qv2ray, saying that the system proxy isn't working at all. astonished, we have checked in detail, but to find that the $https_proxy environmental variable was incorrectly set.

in his case, Qv2ray have a HTTP proxy at 127.0.0.1:8888. Qv2ray configures system proxy through gsettings, and thus triggered that proxy.go, which is used to sync gsettings into environmental variables. $http_proxy variable was correctly set to http://127.0.0.1:8888, but $https_proxy variable was incorrectly set to https://127.0.0.1:8888. since HTTP proxy can't accept HTTPS requests at all, the victim's browser refused to work whenever he wanted to open a HTTPS site, and that's how the problem was discovered.

🕊️ 🕊️ 🕊️ 🕊️ 🕊️ 🕊️ 🕊️

joke

Qv2ray/Qv2ray#589

calendar

SUN	MON	TUE	WED	THU	FRI	SAT
🐛	🕊️	🕊️	🕊️	🕊️	🕊️	🕊️
🕊️	🕊️	🕊️	🕊️	🕊️	🕊️	🕊️
🕊️	🕊️	🕊️	🕊️	🕊️	🕊️	🕊️

DOVE OVERFLOW

[ghost]

As far as I could tell, the https_proxy environment variable can be even socks5:// scheme.

Setting it to plain https without checking is not acceptable.

[ChungZH]

救救孩子吧，自从用了 DDE，只要一设置系统代理，不仅浏览器上不去 HTTPS 的站，更新个系统都会卡死，都要绝望了

🕊️ 🕊️ 🕊️ 🕊️ 🕊️ 🕊️

想挂个代理滚个系统都当场爆毙~

[DuckSoft]

补丁已合并，但上游放出修复过的版本还需要时间。
先关闭了。

[suyar]

至今还没更新吗，deepin20 beta 截止 2020/08/19 还没解决，还是有同样的问题，救救孩子吧

[muihiuwev]

till 21 aug, still the same, so help me god.

[CoelacanthusHex]

@DuckSoft 建议 Reopen, 不然我觉得 deepin 可能会遗忘这个问题……

BTW, I think this patch for so BAD bug should be backported.

[XMuli]

补丁已合并，但上游放出修复过的版本还需要时间。

「English:」
Previously, pr was incorrectly submitted to the develop branch (due to the strategy, the branch is shelved), the latest and most comprehensive branch, usually the default branch uos / master branch (recommended merge branch); then this problem, just now, has been with the backend Team communication suggestion, if possible, let users write the complete string themselves (deepin does not do any splicing and verification), and it is ready to be repaired by hand;

Supplement: If it is a pr from github, if it is merged, it is updated synchronously in real time (only the default branch). After a few minutes, you can see the code submitted by contributors in the default branch. If this is not the case, where might it be? What went wrong, you need to troubleshoot it (there are also internal submissions, which may cause some kind of collision~; there is also a manpower problem~);

For this kind of problem that everyone actually needs, the community has always been willing and has always maintained an open and cooperative mentality~ to build a better experience together.

---

「中文原文:」
先前 pr 都错误的提交到 develop 分支（由于策略，是搁置的分支），最新的最全的分支，通常是默认分支 uos / master 分支（推荐合并分支）； 然后这个问题，刚才，已经和后端团队沟通建议，可以的话，让用户自己来写 完整字符串（deepin 不做任何的拼接和校验），已经准备作手修复了；

补充：如果是来自 github 的 pr， 若是被合并，是实时同步更新（仅默认分支），几分钟后，就可以在默认分支看到来自贡献者提交的代码， 若非这种情况，则可能是哪里出了什么问题，需要进行排查一下（还有来自内部的提交，可能会造成某种碰撞~；还有一个人手问题~）；

对于这种大家都实际都有所需的问题，社区一直愿意和一直保持开放合作的心态~，一起构建更好的使用体验

[XMuli]

Update:

@DuckSoft It has been fixed f3021d13975a [Branch in uos], if there is still a problem, please communicate with @XMuli ; remove this problem for users of deepin or dde which is troublesome

[DuckSoft]

Appreciate! I'll close this issue and remove that hint in Qv2ray/Qv2ray#589 once the fix is published and confirmed.

Update:

@DuckSoft It has been fixed f3021d13975a [Branch in uos], if there is still a problem, please communicate with @XMuli ; remove this problem for users of deepin or dde which is troublesome

[XMuli]

@DuckSoft thanks

[RigoLigoRLC]

Thanks, this bug is finally fixed here.

[ghost]

Thanks for your hard work, the removal of the prompts will be released soon in the alpha preview.
By the way, does deepin have any other portal to report bugs? A 5-months-long delay for a simple proxy setting is not what users expected to.

[XMuli]

I'm sure many of you are wondering why a simple merge is taking so long, but in the next few days I'll write up the reasons why, and answer any questions you may have.

Fortunately, now that the community version code is up to date and in the latest code, if there are any problems later, feedback and bugs will be fixed much more quickly.

[RigoLigoRLC]

Haha...it appears that after the upgrade from 20 (1003) to 20.1 (1010), this problem revived ONCE AGAIN! ROFL

[RigoLigoRLC]

Request a re-open for this issue! Someone uncommented the problematic code WITHOUT EVEN READING GIT BLAME!
a1b16c4 This is so hilarious. UnionTech company, what are you doing? I'm genuinely pissed.

Keep this issue open until the upstream push the updates that will fix this issue. AND FIX THE APPSTORE NOT DAEMON!

[RigoLigoRLC]

I proposed a change in deepin go-lib: to set the envs correctly, not the "how not to set proxy server" way in legacy code.
#26

[XMuli]

Request a re-open for this issue! Someone uncommented the problematic code WITHOUT EVEN READING GIT BLAME!
a1b16c4 This is so hilarious. UnionTech company, what are you doing? I'm genuinely pissed.

Keep this issue open until the upstream push the updates that will fix this issue. AND FIX THE APPSTORE NOT DAEMON!

I understand how you feel. A seemingly retarded action has its reasons.
This commit is a reluctant decision, for which see Qv2ray 检测到 DDE 环境，提示弹窗：Deepin 设置代理错误

This web proxy section, which is already being redesigned and implemented

[RigoLigoRLC]

Request a re-open for this issue! Someone uncommented the problematic code WITHOUT EVEN READING GIT BLAME!
a1b16c4 This is so hilarious. UnionTech company, what are you doing? I'm genuinely pissed.

Keep this issue open until the upstream push the updates that will fix this issue. AND FIX THE APPSTORE NOT DAEMON!

I understand how you feel. A seemingly retarded action has its reasons.
This commit is a reluctant decision, for which see Qv2ray 检测到 DDE 环境，提示弹窗：Deepin 设置代理错误

This web proxy section, which is already being redesigned and implemented

Okay. But why they're not doing as what I proposed in the pull request?

That should be a proper fix for the app store problem.

[DuckSoft]

Finally! Thank you all!