Add optional including of eglfs platform plugins using ENABLE_EGLFS environment variable #98
Conversation
|
Is there a reason other than bloat that prevents us from shipping those plugins by default? What is your use case? Do you have an application on GitHub that needs this which I could have a look at? |
|
Hi @TheAssassin The egl platform plugin has a few different integrations. So when we launch a Qt app with -platform eglfs it selects which eglfs integration to use. I'm trying to create an AppImage for the Rapsberry Pi OS Lite version, so no X11 there. EGLFS is used on a lot of other embedded platforms too. Only other issue I have now is the bluetooth qml module is not getting deployed even tho I added it to the QML_MODULES_PATHS, but that's for an other PR :) |
| @@ -17,8 +17,23 @@ bool PlatformPluginsDeployer::deploy() { | |||
|
|
|||
| ldLog() << "Deploying platform plugins" << std::endl; | |||
|
|
|||
| if (!appDir.deployLibrary(qtPluginsPath / "platforms/libqxcb.so", appDir.path() / "usr/plugins/platforms/")) | |||
| return false; | |||
| if (getenv("ENABLE_EGLFS")){ | |||
| if (!appDir.deployLibrary(qtPluginsPath / "platforms/libqxcb.so", appDir.path() / "usr/plugins/platforms/")) | ||
| return false; | ||
| if (getenv("ENABLE_EGLFS")){ | ||
| if (!appDir.deployLibrary(qtPluginsPath / "platforms/libqxcb.so", appDir.path() / "usr/plugins/platforms/")) |
There was a problem hiding this comment.
This should be refactored into a loop.
| if (!appDir.deployLibrary(qtPluginsPath / "egldeviceintegrations/libqeglfs-kms-emu-integration.so", appDir.path() / "usr/plugins/egldeviceintegrations/")) | ||
| ldLog() << "No EGLFS EMU Integration plugin found, skipping" << std::endl; | ||
| } else { | ||
| if (!appDir.deployLibrary(qtPluginsPath / "platforms/libqxcb.so", appDir.path() / "usr/plugins/platforms/")) |
There was a problem hiding this comment.
The term "enable" implies that enabling the env var just adds additional files. But that's not true: it is more like "either egl or xcb". The name or at least the docs should reflect that. I think USE_ would be a better prefix in the current state.
Can xcb be deployed safely next to egl?
There was a problem hiding this comment.
yes, by default they're both installed on Debian, you select the platform plugin with --plugin flag or an environment variable
|
Ping @viktorgino. I'd like this to get merged. |
No description provided.