Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move moby components that do not have runtime dependencies to own directory #4039

Merged
merged 1 commit into from
May 7, 2024

Conversation

deitch
Copy link
Collaborator

@deitch deitch commented May 7, 2024

- What I did

The source directory src/cmd/linuxkit/moby/ contains all of the following:

  • types
  • utility functions (mostly related to those types)
  • complex functions, those that actually build images, or convert them to/from formats, etc.

This means that anything that accesses or imports the types or utility functions also imports the dependencies of the complex functions, which means pulling in docker, etc., with all of the dependency management that implies.

This PR moves the first two into src/cmd/linuxkit/moby/util/, so it is possible to import those without all of the rest.

In retrospect, I easily could have done the reverse: leave those in moby/ and move the complex ones into moby/build/ or similar, but this worked fine.

- How I did it

Created a directory, moved files over, figured out vet issues, fixed them.

- How to verify it

CI. No change in functionality, so either it works or it doesn't.

- Description for the changelog

Internal split of functionality between packages for moby.

@deitch
Copy link
Collaborator Author

deitch commented May 7, 2024

OK, I changed my mind and reversed it. Types are in moby/ and build functions (that depend on them) are in moby/build/

…ectory

Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch deitch merged commit 6d37353 into linuxkit:master May 7, 2024
22 checks passed
@deitch deitch deleted the split-moby branch May 7, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant