move moby components that do not have runtime dependencies to own directory #4039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
The source directory
src/cmd/linuxkit/moby/
contains all of the following:This means that anything that accesses or imports the types or utility functions also imports the dependencies of the complex functions, which means pulling in docker, etc., with all of the dependency management that implies.
This PR moves the first two into
src/cmd/linuxkit/moby/util/
, so it is possible to import those without all of the rest.In retrospect, I easily could have done the reverse: leave those in
moby/
and move the complex ones intomoby/build/
or similar, but this worked fine.- How I did it
Created a directory, moved files over, figured out vet issues, fixed them.
- How to verify it
CI. No change in functionality, so either it works or it doesn't.
- Description for the changelog
Internal split of functionality between packages for moby.